You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/27 17:55:26 UTC
[GitHub] [airflow] vikramkoka opened a new pull request #10609: Added a logging and monitoring architecture diagram and page
vikramkoka opened a new pull request #10609:
URL: https://github.com/apache/airflow/pull/10609
Added a logging and monitoring architecture diagram and page into the logging and monitoring section of the docs.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vikramkoka commented on a change in pull request #10609: Added a logging and monitoring architecture diagram and page
Posted by GitBox <gi...@apache.org>.
vikramkoka commented on a change in pull request #10609:
URL: https://github.com/apache/airflow/pull/10609#discussion_r478746478
##########
File path: docs/logging-monitoring/logging-architecture.rst
##########
@@ -0,0 +1,41 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+
+Logging and Monitoring architecture
+===================================
+
+Airflow supports a variety of logging and monitoring mechanisms as shown below.
+
+.. image:: ../img/arch-diag-logging.png
+
+By default, Airflow supports logging into the local file system. These include logs from the Web server, the Scheduler, and the Workers running tasks. This is suitable for development environments and for quick debugging.
+
+For cloud deployments, Airflow also has hooks contributed by the Community for logging to cloud storage such as AWS, GCP, and Azure.
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10609: Added a logging and monitoring architecture diagram and page
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10609:
URL: https://github.com/apache/airflow/pull/10609#discussion_r478665332
##########
File path: docs/logging-monitoring/logging-architecture.rst
##########
@@ -0,0 +1,41 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+
+Logging and Monitoring architecture
+===================================
+
+Airflow supports a variety of logging and monitoring mechanisms as shown below.
+
+.. image:: ../img/arch-diag-logging.png
+
+By default, Airflow supports logging into the local file system. These include logs from the Web server, the Scheduler, and the Workers running tasks. This is suitable for development environments and for quick debugging.
+
+For cloud deployments, Airflow also has hooks contributed by the Community for logging to cloud storage such as AWS, GCP, and Azure.
Review comment:
GCP => Google Cloud
See: https://developers.google.com/style/word-list#gcp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10609: Added a logging and monitoring architecture diagram and page
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10609:
URL: https://github.com/apache/airflow/pull/10609#discussion_r478653764
##########
File path: docs/logging-monitoring/logging-architecture.rst
##########
@@ -0,0 +1,41 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+
+Logging and Monitoring architecture
Review comment:
What do you think to move this section up?
https://airflow.readthedocs.io/en/latest/logging-monitoring/index.html
This page is very empty and has been waiting for someone to contribute to the introduction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10609: Added a logging and monitoring architecture diagram and page
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10609:
URL: https://github.com/apache/airflow/pull/10609#discussion_r478655046
##########
File path: docs/logging-monitoring/logging-architecture.rst
##########
@@ -0,0 +1,41 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+
+Logging and Monitoring architecture
+===================================
+
+Airflow supports a variety of logging and monitoring mechanisms as shown below.
+
+.. image:: ../img/arch-diag-logging.png
+
+By default, Airflow supports logging into the local file system. These include logs from the Web server, the Scheduler, and the Workers running tasks. This is suitable for development environments and for quick debugging.
+
+For cloud deployments, Airflow also has hooks contributed by the Community for logging to cloud storage such as AWS, GCP, and Azure.
Review comment:
hooks => handlers or task handlers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10609: Added a logging and monitoring architecture diagram and page
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10609:
URL: https://github.com/apache/airflow/pull/10609#discussion_r478726133
##########
File path: docs/logging-monitoring/logging-architecture.rst
##########
@@ -0,0 +1,41 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+
+Logging and Monitoring architecture
+===================================
+
+Airflow supports a variety of logging and monitoring mechanisms as shown below.
+
+.. image:: ../img/arch-diag-logging.png
+
+By default, Airflow supports logging into the local file system. These include logs from the Web server, the Scheduler, and the Workers running tasks. This is suitable for development environments and for quick debugging.
+
+For cloud deployments, Airflow also has hooks contributed by the Community for logging to cloud storage such as AWS, GCP, and Azure.
Review comment:
Can you create a new PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #10609: Added a logging and monitoring architecture diagram and page
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #10609:
URL: https://github.com/apache/airflow/pull/10609
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10609: Added a logging and monitoring architecture diagram and page
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10609:
URL: https://github.com/apache/airflow/pull/10609#discussion_r478653764
##########
File path: docs/logging-monitoring/logging-architecture.rst
##########
@@ -0,0 +1,41 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+
+Logging and Monitoring architecture
Review comment:
What do you think to move this section up?
https://airflow.readthedocs.io/en/latest/logging-monitoring/index.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vikramkoka commented on a change in pull request #10609: Added a logging and monitoring architecture diagram and page
Posted by GitBox <gi...@apache.org>.
vikramkoka commented on a change in pull request #10609:
URL: https://github.com/apache/airflow/pull/10609#discussion_r478676803
##########
File path: docs/logging-monitoring/logging-architecture.rst
##########
@@ -0,0 +1,41 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+
+Logging and Monitoring architecture
Review comment:
Sure, that's a good idea. I will move it up and add to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org