[GitHub] [geode] DonalEvans commented on a diff in pull request #7680: GEODE-10297: Create SSLContext using default protocols

[GitBox <gi...@apache.org>]

DonalEvans commented on code in PR #7680:
URL: https://github.com/apache/geode/pull/7680#discussion_r871551644


##########
geode-core/src/main/java/org/apache/geode/internal/net/SSLUtil.java:
##########
@@ -36,48 +35,15 @@
 
 public class SSLUtil {
   /**
-   * This is a list of the algorithms that are tried, in order, when "any" is specified. Update
+   * This is a list of the algorithms that are tried, in order, to create an SSLContext. Update
    * this list as new algorithms become available and are supported by Geode. Remove old,
    * no-longer trusted algorithms.
    */
   static final String[] DEFAULT_ALGORITHMS = {"TLSv1.3", "TLSv1.2"};

Review Comment:
   Good call. I think `SUPPORTED_CONTEXTS` is best, since my understanding is that these contexts both technically allow support for other protocols.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org