[GitHub] [lucene-solr] janhoy commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

[GitBox <gi...@apache.org>]

janhoy commented on a change in pull request #1758:
URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r473907204



##########
File path: solr/core/src/java/org/apache/solr/cluster/events/ScheduledEvent.java
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.cluster.events;
+
+/**
+ *
+ */
+public interface ScheduledEvent extends ClusterEvent {

Review comment:
       Is the package system mature enough to handle a dependency graph? I.e 3rd party pks A ---> 1st party pkg B ---> 1st party package C? Would attempt to install A give an error that B must be installed first? Or would install of A trigger auto install of (1st party) pkg B?
   
   I'd prefer to not go there yet, and let packages depend on core APIs only as of now.
   
   We could perhaps make schedulers pluggable, and only include a very slim `TimeIntervalScheduler` in core, and let plugins add their more complex schedulers such as `CronScheduler` as part of the package if needed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org