You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/05/20 09:51:29 UTC
[GitHub] [pinot] richardstartin commented on a diff in pull request #8746: Add a test for nested predicates on startree index
richardstartin commented on code in PR #8746:
URL: https://github.com/apache/pinot/pull/8746#discussion_r877961710
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/StarTreeClusterIntegrationTest.java:
##########
@@ -203,6 +203,12 @@ public void testPredicateOnMetrics()
"SELECT SUM(DepDelayMinutes) FROM myStarTable WHERE DepDelay > 0 AND ArrDelay > 0 AND OriginStateName = "
+ "'Massachusetts'";
testStarQuery(starQuery);
+
+ // Query containing predicate with nested OR and ANDs
+ starQuery =
+ "SELECT SUM(DepDelayMinutes) FROM myStarTable WHERE ((DepDelay > 0 AND ArrDelay > 0) OR (OriginStateName = "
Review Comment:
Could you also add one with a count?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org