You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/12/10 01:53:25 UTC
[GitHub] [mynewt-mcumgr] vrahane commented on a change in pull request #46:
Zephyr support
vrahane commented on a change in pull request #46: Zephyr support
URL: https://github.com/apache/mynewt-mcumgr/pull/46#discussion_r355790100
##########
File path: cborattr/src/cborattr.c
##########
@@ -17,24 +17,25 @@
* under the License.
*/
-//#include <syscfg/syscfg.h>
#include "cborattr/cborattr.h"
-#include "tinycbor/cbor.h"
-#include "tinycbor/cbor_buf_reader.h"
+
+#ifdef __ZEPHYR__
+#include <zephyr.h>
+#include <cbor.h>
+#include <cbor_buf_reader.h>
+#define CBORATTR_MAX_SIZE CONFIG_MGMT_CBORATTR_MAX_SIZE
+#endif
Review comment:
Same comment as above, the constant can stay and so would the zephyr include.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services