You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/07/29 21:42:47 UTC

[PR] Skip contributor template check for bot User accounts (e.g. renovate-bot) [texera]

Yicong-Huang opened a new pull request, #7062:
URL: https://github.com/apache/texera/pull/7062

### What changes were proposed in this PR?

The `contributor-checks` job in `.github/workflows/contributor-checks.yml` gates on `github.event.sender.type != 'Bot'` so it won't nag automated PR/issue openers about not following the template.

That gate catches GitHub App bots (e.g. `dependabot[bot]`, whose account `type` is `Bot`) but **not** bots that run under a regular User account. Renovate's `renovate-bot` account has `type: User`, so it slipped through and received the "the description doesn't follow our template" warning on every dependency-update PR (e.g. [#7060](https://github.com/apache/texera/pull/7060#issuecomment-5123597082)).

This PR additionally skips senders whose login ends in `-bot`, covering `renovate-bot` and any future User-account bots:

```yaml
if: >-
github.event.sender.type != 'Bot' &&
!endsWith(github.event.sender.login, '-bot')
```

### How was this PR tested?

- Confirmed via the GitHub API that `renovate-bot` has `type: User` (not `Bot`), which is why the existing `sender.type != 'Bot'` gate did not exclude it.
- Validated the workflow YAML parses and the folded `if:` expression resolves to the intended single-line condition.
- The change is confined to the job-level `if:` gate; no `run:` step or untrusted-input interpolation is touched.

### Was this PR authored or co-authored using generative AI tooling?

Yes — drafted with Claude Code, reviewed by the author.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ci: skip contributor template check for renovate-bot's User account [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.

Yicong-Huang merged PR #7062:
URL: https://github.com/apache/texera/pull/7062


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Skip contributor template check for renovate-bot [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #7062:
URL: https://github.com/apache/texera/pull/7062#issuecomment-5123708603

   <!-- texera-benchmarks-comment -->
   ## ⚠️ Benchmark changes need a look
   
   🟢 4 better · 🔴 2 worse · ⚪ 9 noise (<±5%) · 0 without baseline
   
   > Compared against main `02ae12b` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
   
   [Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/30493438740)
   
   | | config | throughput | MB/s | latency | max Δ latest / 7d |
   |---|---|---:|---:|---:|---:|
   | 🔴 | bs=10 sw=10 sl=64 | 551 | 0.336 | 17,573/23,210/23,210 us | 🔴 +8.1% / 🔴 +47.1% |
   | 🔴 | bs=100 sw=10 sl=64 | 1,191 | 0.727 | 82,464/111,035/111,035 us | 🔴 +6.6% / 🟢 +19.1% |
   | ⚪ | bs=1000 sw=10 sl=64 | 1,422 | 0.868 | 697,398/743,145/743,145 us | ⚪ within ±5% / 🟢 +37.9% |
   
   <details><summary>Baseline details</summary>
   
   Latest main `02ae12b` from same runner
   
   | config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
   |---|---|---:|---:|---:|---:|---:|
   | bs=10 sw=10 sl=64 | throughput | 551 tuples/sec | 579 tuples/sec | 786.12 tuples/sec | -4.8% | -29.9% |
   | bs=10 sw=10 sl=64 | MB/s | 0.336 MB/s | 0.353 MB/s | 0.48 MB/s | -4.8% | -30.0% |
   | bs=10 sw=10 sl=64 | p50 | 17,573 us | 16,254 us | 12,305 us | +8.1% | +42.8% |
   | bs=10 sw=10 sl=64 | p95 | 23,210 us | 24,655 us | 15,774 us | -5.9% | +47.1% |
   | bs=10 sw=10 sl=64 | p99 | 23,210 us | 24,655 us | 18,978 us | -5.9% | +22.3% |
   | bs=100 sw=10 sl=64 | throughput | 1,191 tuples/sec | 1,215 tuples/sec | 999.71 tuples/sec | -2.0% | +19.1% |
   | bs=100 sw=10 sl=64 | MB/s | 0.727 MB/s | 0.741 MB/s | 0.61 MB/s | -1.9% | +19.1% |
   | bs=100 sw=10 sl=64 | p50 | 82,464 us | 77,351 us | 100,616 us | +6.6% | -18.0% |
   | bs=100 sw=10 sl=64 | p95 | 111,035 us | 117,876 us | 107,356 us | -5.8% | +3.4% |
   | bs=100 sw=10 sl=64 | p99 | 111,035 us | 117,876 us | 113,255 us | -5.8% | -2.0% |
   | bs=1000 sw=10 sl=64 | throughput | 1,422 tuples/sec | 1,429 tuples/sec | 1,031 tuples/sec | -0.5% | +37.9% |
   | bs=1000 sw=10 sl=64 | MB/s | 0.868 MB/s | 0.872 MB/s | 0.63 MB/s | -0.5% | +37.9% |
   | bs=1000 sw=10 sl=64 | p50 | 697,398 us | 700,117 us | 980,328 us | -0.4% | -28.9% |
   | bs=1000 sw=10 sl=64 | p95 | 743,145 us | 744,294 us | 1,027,528 us | -0.2% | -27.7% |
   | bs=1000 sw=10 sl=64 | p99 | 743,145 us | 744,294 us | 1,054,298 us | -0.2% | -29.5% |
   
   </details>
   
   <details><summary>Raw CSV</summary>
   
   ```csv
   config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
   0,10,10,64,20,362.79,200,128000,551,0.336,17573.36,23209.68,23209.68
   1,100,10,64,20,1679.83,2000,1280000,1191,0.727,82464.20,111034.60,111034.60
   2,1000,10,64,20,14066.68,20000,12800000,1422,0.868,697397.99,743144.65,743144.65
   ```
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Skip contributor template check for bot User accounts (e.g. renovate-bot) [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #7062:
URL: https://github.com/apache/texera/pull/7062#issuecomment-5123670314

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - No candidates found from `git blame` history.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org