You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "HaoYang670 (via GitHub)" <gi...@apache.org> on 2023/04/20 09:01:17 UTC
[GitHub] [kyuubi] HaoYang670 opened a new pull request, #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
HaoYang670 opened a new pull request, #4740:
URL: https://github.com/apache/kyuubi/pull/4740
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
Closes #4738
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#discussion_r1172366930
##########
.gitignore:
##########
@@ -32,6 +32,8 @@
.ensime_lucene
.generated-mima*
.vscode/
+.bloop/
Review Comment:
what's this for? vscode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on a diff in pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on code in PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#discussion_r1172368995
##########
.gitignore:
##########
@@ -32,6 +32,8 @@
.ensime_lucene
.generated-mima*
.vscode/
+.bloop/
Review Comment:
This is for scala metals: https://github.com/scalameta/metals
I will remove it if you think it is not good to add them in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1520424148
Thanks, merged to master/1.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1519448941
How can I get the name of the primary group of the `Utils.currentUser`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
URL: https://github.com/apache/kyuubi/pull/4740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#discussion_r1172372697
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -355,9 +355,15 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
private def getEngineSpace(engine: Engine): String = {
val serverSpace = fe.getConf.get(HA_NAMESPACE)
+ val owner = if (engine.getSharelevel == "GROUP") {
Review Comment:
the SERVER mode is not correct either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] zwangsheng commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1518932076
Also, cc @lightning-L as original author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] huangzhir commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "huangzhir (via GitHub)" <gi...@apache.org>.
huangzhir commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1521365765
> Hi @bowenliang123. I create #4770 to track this. But I am afraid I can't give a quick fix because it is a low priority in my task list. Sorry from that.
@HaoYang670 @bowenliang123 I have some free time, can I fix this bug https://github.com/apache/kyuubi/issues/4770 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on a diff in pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on code in PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#discussion_r1172372396
##########
.gitignore:
##########
@@ -32,6 +32,8 @@
.ensime_lucene
.generated-mima*
.vscode/
+.bloop/
Review Comment:
OK. I will clean them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on a diff in pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on code in PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#discussion_r1173549313
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -355,9 +355,15 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
private def getEngineSpace(engine: Engine): String = {
val serverSpace = fe.getConf.get(HA_NAMESPACE)
+ val owner = if (engine.getSharelevel == "GROUP") {
Review Comment:
> the SERVER mode is not correct either
Could this be in another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on a diff in pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on code in PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#discussion_r1173548710
##########
.gitignore:
##########
@@ -32,6 +32,8 @@
.ensime_lucene
.generated-mima*
.vscode/
+.bloop/
Review Comment:
Cleaned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] zwangsheng commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1521389328
> > > Hi @bowenliang123. I create #4770 to track this. But I am afraid I can't give a quick fix because it is a low priority in my task list. Sorry from that.
> >
> >
> > @HaoYang670 @bowenliang123 I have some free time, can I fix this bug #4770 ?
>
> Cool, thanks for giving a hand in this. If we won't be able to fix this soon, I think we shall consider reverting this on branch-1.7 to prevent blocking the release process.
I will fix it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] zwangsheng commented on a diff in pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on code in PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#discussion_r1172324551
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -355,9 +355,15 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
private def getEngineSpace(engine: Engine): String = {
val serverSpace = fe.getConf.get(HA_NAMESPACE)
+ val owner = if (engine.getSharelevel == "GROUP") {
Review Comment:
Reference `EngineRef`, using the scala syntax
```
engine.getSharelevel match {
case XXX =>
// do something
case _ =>
// do something
}
```
##########
.gitignore:
##########
@@ -32,6 +32,8 @@
.ensime_lucene
.generated-mima*
.vscode/
+.bloop/
Review Comment:
Please not introduce extraneous changes
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -355,9 +355,15 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
private def getEngineSpace(engine: Engine): String = {
val serverSpace = fe.getConf.get(HA_NAMESPACE)
+ val owner = if (engine.getSharelevel == "GROUP") {
Review Comment:
owner => appUser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#discussion_r1172371388
##########
.gitignore:
##########
@@ -32,6 +32,8 @@
.ensime_lucene
.generated-mima*
.vscode/
+.bloop/
Review Comment:
it's fine, but better in a separated PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1519421406
> would you like to add a unit test of the list engine and delete engine in Group level?
Sure I'd like to. But could you please help on how to implement a `GroupProvider` in the unit test?
I've found you are using the "hadoop" provider, how should I reuse it in the group share level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1516078705
## [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4740?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4740](https://codecov.io/gh/apache/kyuubi/pull/4740?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df528ff) into [master](https://codecov.io/gh/apache/kyuubi/commit/cba1be97399c2f8370fd1120059916511591e2cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cba1be9) will **decrease** coverage by `0.04%`.
> The diff coverage is `60.00%`.
```diff
@@ Coverage Diff @@
## master #4740 +/- ##
============================================
- Coverage 58.04% 58.00% -0.04%
Complexity 13 13
============================================
Files 581 581
Lines 32297 32300 +3
Branches 4313 4314 +1
============================================
- Hits 18746 18735 -11
- Misses 11750 11763 +13
- Partials 1801 1802 +1
```
| [Impacted Files](https://codecov.io/gh/apache/kyuubi/pull/4740?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/server/api/v1/AdminResource.scala](https://codecov.io/gh/apache/kyuubi/pull/4740?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0FkbWluUmVzb3VyY2Uuc2NhbGE=) | `83.75% <50.00%> (-0.97%)` | :arrow_down: |
| [...ache/kyuubi/server/KyuubiRestFrontendService.scala](https://codecov.io/gh/apache/kyuubi/pull/4740?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `82.17% <100.00%> (ø)` | |
... and [9 files with indirect coverage changes](https://codecov.io/gh/apache/kyuubi/pull/4740/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1521342224
Hi, with this PR merged to `branch-1.7`, several missing types and values cause compilation failures.
```
[ERROR] [Error] /Users/bw/dev/kyuubi/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala:169: not found: type KyuubiRestFrontendService
[ERROR] [Error] /Users/bw/dev/kyuubi/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala:184: not found: value encodeAuthorization
[ERROR] [Error] /Users/bw/dev/kyuubi/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala:303: not found: type KyuubiRestFrontendService
[ERROR] [Error] /Users/bw/dev/kyuubi/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala:317: not found: value encodeAuthorization
[ERROR] four errors found
```
Could you raise a follow-up PR to fix this for `branch-1.7` ? @HaoYang670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1515978484
I will add `test("list engine - group share level")` in `AdminResourceSuite`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1521369115
> > Hi @bowenliang123. I create #4770 to track this. But I am afraid I can't give a quick fix because it is a low priority in my task list. Sorry from that.
>
> @HaoYang670 @bowenliang123 I have some free time, can I fix this bug #4770 ?
Cool, thanks for giving a hand in this. If we won't be able to fix this soon, I think we shall consider reverting this on branch-1.7 to prevent blocking the release process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1519488358
Hi @zwangsheng @pan3793 Thank you for reviewing and helping. I've added tests. Could we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] zwangsheng commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1519443731
> > would you like to add a unit test of the list engine and delete engine in Group level?
>
> Sure I'd like to. But could you please help on how to implement a `GroupProvider` in the unit test? I've found you are using the "hadoop" provider, how should I reuse it in the group share level?
>
> https://github.com/apache/kyuubi/blob/6ba8b99151adeee2fbdc7127a1ec1b0a087d4787/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala#L266-L269
According to current impl, you can also get `fe` in suite (You may need cast `fe` => `KyuubiRestFrontendService`).
Then `fe.sessionManager.groupProvider`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1519502137
the code LGTM, please run `dev/reformat` to fix the style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1519505263
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on a diff in pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on code in PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#discussion_r1173549035
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##########
@@ -355,9 +355,15 @@ private[v1] class AdminResource extends ApiRequestContext with Logging {
private def getEngineSpace(engine: Engine): String = {
val serverSpace = fe.getConf.get(HA_NAMESPACE)
+ val owner = if (engine.getSharelevel == "GROUP") {
Review Comment:
Updated. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] HaoYang670 commented on pull request #4740: [KYUUBI #4738] `AdminResource.getEngineSpace` should use primary group name on GROUP share level
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on PR #4740:
URL: https://github.com/apache/kyuubi/pull/4740#issuecomment-1521356549
Hi @bowenliang123. I create #4770 to track this. But I am afraid I can't give a quick fix because it is a low priority in my task list. Sorry from that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org