[GitHub] spark pull request #17489: [SPARK-20166][SQL] Use XXX for ISO 8601 timezone ...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17489#discussion_r109083697
  
    --- Diff: python/pyspark/sql/readwriter.py ---
    @@ -363,7 +363,7 @@ def csv(self, path, schema=None, sep=None, encoding=None, quote=None, escape=Non
             :param timestampFormat: sets the string that indicates a timestamp format. Custom date
                                     formats follow the formats at ``java.text.SimpleDateFormat``.
                                     This applies to timestamp type. If None is set, it uses the
    -                                default value, ``yyyy-MM-dd'T'HH:mm:ss.SSSZZ``.
    +                                default value, ``yyyy-MM-dd'T'HH:mm:ss.SSSXXX``.
    --- End diff --
    
    interestingly, the default format value in R omits the timezone. I think this is an issue that we need to fix (think we have seen some test failure reported by someone in India a while back)
    https://github.com/apache/spark/blame/master/R/pkg/R/functions.R#L2844


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org