You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "HBase QA (JIRA)" <ji...@apache.org> on 2019/05/24 13:43:01 UTC
[jira] [Commented] (HBASE-22469) replace md5 checksum in
saveVersion script with sha512 for hbase version information
[ https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847556#comment-16847556 ]
HBase QA commented on HBASE-22469:
----------------------------------
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 50s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 8s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 1m 16s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/PreCommit-HBASE-Build/415/artifact/patchprocess/Dockerfile |
| JIRA Issue | HBASE-22469 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12969642/HBASE-22469.v01.patch |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 9e8d48d0ce22 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 96d2aabfad |
| maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| shellcheck | v0.4.4 |
| Max. process+thread count | 40 (vs. ulimit of 10000) |
| modules | C: hbase-common U: hbase-common |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/415/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> replace md5 checksum in saveVersion script with sha512 for hbase version information
> ------------------------------------------------------------------------------------
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
> Reporter: Artem Ervits
> Assignee: Artem Ervits
> Priority: Minor
> Attachments: HBASE-22469.v01.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we long retired md5 from the releases, it makes sense to replace hbase version information as well. I also noticed that revision doesn't always show, case in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only appears if the compiled code was cloned from git and not a release candidate download file. In that sense, release candidates should be checked out rather than downloaded. This Jira only addresses replacement of the md5 sum.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)