You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2020/05/07 09:34:16 UTC

[GitHub] [mesos] cf-natali commented on a change in pull request #362: Keep retrying to remove cgroup on EBUSY.

cf-natali commented on a change in pull request #362:
URL: https://github.com/apache/mesos/pull/362#discussion_r421370904



##########
File path: src/linux/cgroups.cpp
##########
@@ -291,8 +290,9 @@ Future<Nothing> remove(const string& hierarchy, const string& cgroup)
       [=](const Nothing&) mutable -> Future<ControlFlow<Nothing>> {
         if (::rmdir(path.c_str()) == 0) {
           return process::Break();
-        } else if ((errno == EBUSY) && (retry > 0)) {
-          --retry;
+        } else if (errno == EBUSY) {
+          LOG(WARNING) << "Removal of cgroup " << path
+                       << " failed with EBUSY, will try again";

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org