You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "youngkermit8-coder (via GitHub)" <gi...@apache.org> on 2026/08/10 22:21:22 UTC
[PR] [ISSUE #1428] Scope topic and group deletes to target cluster [rocketmq-dashboard]
youngkermit8-coder opened a new pull request, #1521:
URL: https://github.com/apache/rocketmq-dashboard/pull/1521
## What changed
- Scope topic deletion broker RPCs to the selected instance's cluster.
- Scope consumer-group deletion RPCs to the same target cluster.
- Resolve the cluster name once per operation and reuse it for broker, NameServer, and metadata cleanup.
- Add dual-cluster regression coverage proving the unrelated cluster does not receive deletion calls.
## Why
PR #1429 fixed the create/update paths described in #1428, but the two delete paths still called `getAllMasterBrokerAddrs(admin)`. In an instance that can see multiple clusters, deleting a topic or consumer group could therefore send the operation to every cluster.
This completes the remaining delete-path scope from #1428 while keeping the existing cluster-resolution behavior.
## Impact
Topic and consumer-group deletions now target only the selected cluster, preventing same-named resources in other clusters from being deleted.
## Validation
Validated after applying this commit on top of the backend compilation fix from #1502 (`c00a5ef`):
- `mvn -Dtest=RocketMQAdminClientImplTest test` — 16 tests passed
- Checkstyle — 0 violations
- `mvn -DskipTests package` — success
Refs #1428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #1428] Scope topic and group operations to target cluster [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1521:
URL: https://github.com/apache/rocketmq-dashboard/pull/1521#issuecomment-5253030713
Rework needed before merge (verified not a duplicate of #1429, which only covered create/update): please rebase onto the current rocketmq-studio HEAD and resolve the RocketMQAdminClientImplTest conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #1428] Scope topic and group operations to target cluster [rocketmq-dashboard]
Posted by "youngkermit8-coder (via GitHub)" <gi...@apache.org>.
youngkermit8-coder commented on PR #1521:
URL: https://github.com/apache/rocketmq-dashboard/pull/1521#issuecomment-5253384441
Rebased onto the current rocketmq-studio head and resolved the RocketMQAdminClientImplTest conflict by retaining both the upstream topic update regression and this PR's cluster-scoped/fail-closed coverage. I also updated the rebased TopicPage assertions for cluster-aware row keys and request payloads. Verification: backend related tests 63/63, frontend related tests 30/30, Checkstyle 0, targeted ESLint 0 errors (one existing Fast Refresh warning), and the production frontend build passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #1428] Scope topic and group operations to target cluster [rocketmq-dashboard]
Posted by "youngkermit8-coder (via GitHub)" <gi...@apache.org>.
youngkermit8-coder commented on PR #1521:
URL: https://github.com/apache/rocketmq-dashboard/pull/1521#issuecomment-5281849515
Synced this branch to the current `rocketmq-studio` head `737a7b4`. The single conflict in `TopicPage` now preserves both the upstream topic-type cards and this PR's cluster-aware row identity/deletion flow. New signed head: `0ca75eb`.
Verification on this exact head:
- backend focused tests: 65/65 passed
- backend full suite: 1152/1152 passed; Checkstyle 0 violations
- frontend focused tests: 21/21 passed
- changed frontend files: ESLint passed
- frontend production build passed
- `git diff --check` passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org