You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/09/11 06:13:55 UTC
[GitHub] [kyuubi] AngersZhuuuu opened a new pull request, #5270: [KYUUBI #5269][Bug] Dupllicated AnalyzesTablesCommand in kyuubi authz
AngersZhuuuu opened a new pull request, #5270:
URL: https://github.com/apache/kyuubi/pull/5270
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
### _Was this patch authored or co-authored using generative AI tooling?_
<!--
If a generative AI tooling has been used in the process of authoring this patch, please include
phrase 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] yaooqinn commented on pull request #5270: [KYUUBI #5269][Bug] Dupllicated AnalyzesTablesCommand in kyuubi authz
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #5270:
URL: https://github.com/apache/kyuubi/pull/5270#issuecomment-1714852663
> - check spec json files *** FAILED ***
Check table_command_spec.json failed. Please regenerate the ranger policy file by running `dev/gen/gen_ranger_spec_json.sh`. generatedStr.equals(existedFileContent) was false (JsonSpecFileGenerator.scala:77)
the test failure is relevant , please update accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] yaooqinn commented on pull request #5270: [KYUUBI #5269][Bug] Dupllicated AnalyzesTablesCommand in kyuubi authz
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #5270:
URL: https://github.com/apache/kyuubi/pull/5270#issuecomment-1713686517
The key concept here is classname of all commands is kinda primary key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] AngersZhuuuu commented on pull request #5270: [KYUUBI #5269][Bug] Dupllicated AnalyzesTablesCommand in kyuubi authz
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #5270:
URL: https://github.com/apache/kyuubi/pull/5270#issuecomment-1714878325
> > * check spec json files *** FAILED ***
> > Check table_command_spec.json failed. Please regenerate the ranger policy file by running `dev/gen/gen_ranger_spec_json.sh`. generatedStr.equals(existedFileContent) was false (JsonSpecFileGenerator.scala:77)
>
> the test failure is relevant , please update accordingly
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] AngersZhuuuu commented on pull request #5270: [KYUUBI #5269][Bug] Dupllicated AnalyzesTablesCommand in kyuubi authz
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #5270:
URL: https://github.com/apache/kyuubi/pull/5270#issuecomment-1713232121
ping @pan3793 @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #5270: [KYUUBI #5269][Bug] Dupllicated AnalyzesTablesCommand in kyuubi authz
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5270:
URL: https://github.com/apache/kyuubi/pull/5270#issuecomment-1714946767
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5270?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5270](https://app.codecov.io/gh/apache/kyuubi/pull/5270?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (75efc1a) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/93021109db4bdb6dc6db9464319b13250a792de9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9302110) will **not change** coverage.
> Report is 6 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #5270 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 590 590
Lines 33345 33345
Branches 4406 4406
======================================
Misses 33345 33345
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] AngersZhuuuu commented on pull request #5270: [KYUUBI #5269][Bug] Dupllicated AnalyzesTablesCommand in kyuubi authz
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #5270:
URL: https://github.com/apache/kyuubi/pull/5270#issuecomment-1713297199
> Sorry. What is it duplicated with? Further evidence and discussion may be required. It seems that they are applied to the same plan of analyzing tables in db, extracting privilege objects for both Databases and Tables.
>
> It's not consistent in the AnalyzeTablesCommand ut as it only asserts one db-level input object. More improvements here could be made to check table-level objects as it's supposed to do.
First. the extractor is wrong, second AnalyzeTableCommand won't be proccesed in table_command_spec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #5270: [KYUUBI #5269][Bug] Dupllicated AnalyzesTablesCommand in kyuubi authz
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #5270:
URL: https://github.com/apache/kyuubi/pull/5270#issuecomment-1713342793
Is that are you're reporting for the problem and reason then?
No description. No investigation proof. No detailed purposed solution. And no test running before submitting this PR. And again , no for all without marking this PR as draft.
Are there any similar violated protocols and behaviours in other OSS projects?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] yaooqinn closed pull request #5270: [KYUUBI #5269][Bug] Dupllicated AnalyzesTablesCommand in kyuubi authz
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #5270: [KYUUBI #5269][Bug] Dupllicated AnalyzesTablesCommand in kyuubi authz
URL: https://github.com/apache/kyuubi/pull/5270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] yaooqinn commented on pull request #5270: [KYUUBI #5269][Bug] Dupllicated AnalyzesTablesCommand in kyuubi authz
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #5270:
URL: https://github.com/apache/kyuubi/pull/5270#issuecomment-1713752359
Hi @AngersZhuuuu AnalyzesTablesCommand shall be removed from java classes, then re-generating the json file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] yaooqinn commented on pull request #5270: [KYUUBI #5269][Bug] Dupllicated AnalyzesTablesCommand in kyuubi authz
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #5270:
URL: https://github.com/apache/kyuubi/pull/5270#issuecomment-1715012726
thanks, merged to master 1.8 and 1.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #5270: [KYUUBI #5269][Bug] Dupllicated AnalyzesTablesCommand in kyuubi authz
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #5270:
URL: https://github.com/apache/kyuubi/pull/5270#issuecomment-1713260566
Sorry. What is it duplicated with? Further evidence and discussion may be required.
As for now, it's applying to the same plan of analyzing tables in db, but extracting privilege object for both Databases and Tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org