You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "codeconsole (via GitHub)" <gi...@apache.org> on 2026/10/17 17:07:42 UTC

[PR] 7.2 (fix): expect the platform's separator from projectPath in the file system interaction specs [grails-core]

codeconsole opened a new pull request, #16664:
URL: https://github.com/apache/grails-core/pull/16664

   `FileSystemInteractionImplSpec` fails on Windows in the feature 81e4dc8373 added, in both copies of the spec:
   
   ```
   interaction.projectPath(missing) == 'nested/missing.txt'
   |           |           |        |
   |           |           |        false
   |           nested\missing.txt
   ```
   
   `projectPath` builds the path from `File.canonicalPath`, which uses the platform's separator, and only messages use it, so the expectation was wrong rather than the code. It is now built as `new File('nested', 'missing.txt').path`.
   
   The failure shows on every Windows run of 8.0.x and 9.0.x, where it came with the merge of 7.2.x. That merge also added a third copy of the spec, `grails-core/src/test-cli`, which needs the same line when this is merged into 8.0.x.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 7.2 (fix): expect the platform's separator from projectPath in the file system interaction specs [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16664:
URL: https://github.com/apache/grails-core/pull/16664#issuecomment-6239857588

   ## ✅ All tests passed ✅
   
   🏷️ Commit: 10cf675644d096dcbb1fd13bcebc451f06a1eba6
   ▶️ Tests:  65491 executed
   ⚪️ Checks: 60/60 completed
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 7.2 (fix): expect the platform's separator from projectPath in the file system interaction specs [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16664:
URL: https://github.com/apache/grails-core/pull/16664#issuecomment-6237890683

   ## 🚨 TestLens detected 1 failed test 🚨
   
   ### Test Summary
   > [!TIP]
   > Inspect all details with the [TestLens CLI](https://testlens.app/docs/features/cli): `testlens pr 16664`
   
   #### [CI / Build Grails-Core \(windows-latest, 25, true\)](https://github.com/apache/grails-core/actions/runs/39052389966/job/117453421713?pr=16664) > :grails-shell-cli:test
   
   | Test | Runs | Flakiness |
   |---|---|--:|
   | RunningApplicationProcessSpec > stop terminates a running process and removes the PID file | ❌ | 0%&nbsp;🟢 |
   
   🏷️ Commit: 9089c2803c182fae2819fb4c8358a5f6ec7b8844
   ▶️ Tests:  45598 executed
   🟡 Checks: 39/54 completed
   
   ### Test Failures
   
   <details><summary><strong>RunningApplicationProcessSpec > stop terminates a running process and removes the PID file</strong> (:grails-shell-cli:test in <a href="https://github.com/apache/grails-core/actions/runs/39052389966/job/117453421713?pr=16664">CI / Build Grails-Core (windows-latest, 25, true)</a>)</summary>
   
   ```
   Condition not satisfied:
   
   !process.isAlive()
   ||       |
   ||       true
   |Process[pid=7412, exitValue=1]
   false
   
   	at org.grails.cli.gradle.RunningApplicationProcessSpec.stop terminates a running process and removes the PID file(RunningApplicationProcessSpec.groovy:217)
   ```
   
   </details>
   
   ### Rerun Controls
   > [!NOTE]
   > Checks are currently running using the configuration below.
   
   Select tests to mute in this pull request:
   
   🔲 RunningApplicationProcessSpec > stop terminates a running process and removes the PID file <!-- uniqueId=[engine:spock]/[spec:org.grails.cli.gradle.RunningApplicationProcessSpec]/[feature:$spock_feature_0_13] -->
   
   Reuse successful test results:
   
   🔲 ♻️ Only rerun the tests that failed or were muted before
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 7.2 (fix): expect the platform's separator from projectPath in the file system interaction specs [grails-core]

Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole merged PR #16664:
URL: https://github.com/apache/grails-core/pull/16664


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org