[GitHub] rafaelweingartner commented on a change in pull request #2639: [CLOUDSTACK-10276] listVolumes not working when storage UUID is not a UUID

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #2639: [CLOUDSTACK-10276] listVolumes not working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#discussion_r187668341
 
 

 ##########
 File path: api/src/org/apache/cloudstack/api/command/admin/volume/ListVolumesCmdByAdmin.java
 ##########
 @@ -34,32 +34,5 @@
 @APICommand(name = "listVolumes", description = "Lists all volumes.", responseObject = VolumeResponse.class, responseView = ResponseView.Full, entityType = {Volume.class},
         requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
 public class ListVolumesCmdByAdmin extends ListVolumesCmd {
-    public static final Logger s_logger = Logger.getLogger(ListVolumesCmdByAdmin.class.getName());
-
-    @Parameter(name=ApiConstants.POD_ID, type=CommandType.UUID, entityType=PodResponse.class,
-            description="the pod id the disk volume belongs to")
-    private Long podId;
 
 Review comment:
   It is in the superclass as well. These parameters were declared twice. One in the "admin" class, and other in the "normal" one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services