[jira] [Comment Edited] (OFBIZ-6212) Accounting reports fail

["Deepak Dixit (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942282#comment-14942282 ] 

Deepak Dixit edited comment on OFBIZ-6212 at 10/3/15 1:47 PM:
--------------------------------------------------------------

IMO no need to create sub-task for accounting broken reports, This should be fixed in Trunk at r#1706577 and 14.12 at r#1706583

It was broken due to empty description string, if description is empty then makeHyperlinkString does not call the makeHyperlinkString macro to render the hyper link and due to this fo:table-cell is render without fo:block and its not a valid syntax of fo:table-cell. Updated the condition and used != null check to allow empty description string. 

We can use    <fo:basic-link > tag to create link FOP, will open new ticket for this.


was (Author: deepak.dixit):
IMO no need to create sub-task for accounting broken reports, This should be fixed in Trunk at r#1706577 and 14.12 at r#1706577

It was broken due to empty description string, if description is empty then makeHyperlinkString does not call the makeHyperlinkString macro to render the hyper link and due to this fo:table-cell is render without fo:block and its not a valid syntax of fo:table-cell. Updated the condition and used != null check to allow empty description string. 

We can use    <fo:basic-link > tag to create link FOP, will open new ticket for this.

> Accounting reports fail
> -----------------------
>
>                 Key: OFBIZ-6212
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6212
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting, specialpurpose/birt
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Deepak Dixit
>         Attachments: OFBIZ-6212-1.patch
>
>
> Below are the issues:
> 1).  http://demo-trunk-ofbiz.apache.org/accounting/control/FinancialSummaryReportOptions?organizationPartyId=Company
> 1st report: groovy file error, others miss request-maps
> 2). http://demo-trunk-ofbiz.apache.org/accounting/control/TrialBalance
> {noformat}
> ERROR rendering error page [/error/error.jsp], but here is the error text: org.ofbiz.widget.renderer.ScreenRenderException:
> Error rendering screen [component://accounting/widget/ReportFinancialSummaryScreens.xml#TrialBalance]: java.lang.IllegalArgumentException:
> Error calling service with name getPartyAccountingPreferences: org.ofbiz.service.ServiceValidationException:
> Le paramètre requis suivant manque : [getPartyAccountingPreferences.organizationPartyId]
> {noformat}
> 3).
> The followings are Birt issues
>     http://demo-trunk-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company (PFD export)
>     http://demo-trunk-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company (PFD export)
> They work in stable demo, there is no Birt there
>     http://demo-stable-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company (PFD export)
>     http://demo-stable-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company (PFD export)
> These issues should be addressed separately in sub-tasks each, I have not time to do that yet...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)