[GitHub] [struts-archetypes] JCgH4164838Gh792C124B5 commented on pull request #6: Minor archetype fixes for generated project unit tests

[GitBox <gi...@apache.org>]

JCgH4164838Gh792C124B5 commented on pull request #6:
URL: https://github.com/apache/struts-archetypes/pull/6#issuecomment-707364557


   Hello @hikaen2 .
   
   I am not sure if it is considered correct behaviour or not, but what you report seems to indicate that `commons-compress` may also be a `runtime` scope dependency for newer JDKs (like JDK 11) and the Conventions archetype, and not just a `test` scope dependency.
   
   If that is the case, then the Conventions archetype should probably have the `commons-compress` dependency modified from `test `to `runtime`.  @lukaszlenart , what do you think ?
   
   If declaring `commons-compress` in `pom.xml` as a `runtime` dependency for the project seems to work, it sounds like it may be the only option.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org