You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Thomas Groh (JIRA)" <ji...@apache.org> on 2016/11/08 21:46:00 UTC

[jira] [Commented] (BEAM-938) Break in direct.UnboundedReadEvaluatorFactoryTest.noElementsAvailableReaderIncludedInResidual

    [ https://issues.apache.org/jira/browse/BEAM-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648883#comment-15648883 ] 

Thomas Groh commented on BEAM-938:
----------------------------------

This was due to an incompletely updated test;

Specifically, the TestUnboundedSource was updated to provide a watermark that always advanced, but {{noElementsAvailableReaderIncludedInResidual}} used an {{UnboundedCountingSource}}

https://github.com/apache/incubator-beam/pull/1303 reverts the test, and https://github.com/apache/incubator-beam/pull/1313 is the complete fix.

> Break in direct.UnboundedReadEvaluatorFactoryTest.noElementsAvailableReaderIncludedInResidual
> ---------------------------------------------------------------------------------------------
>
>                 Key: BEAM-938
>                 URL: https://issues.apache.org/jira/browse/BEAM-938
>             Project: Beam
>          Issue Type: Bug
>            Reporter: Jason Kuster
>            Assignee: Thomas Groh
>             Fix For: 0.4.0-incubating
>
>
> Likely culprit:
> https://github.com/apache/incubator-beam/commit/ff7fe07be96de393b763e7b3d213734040aa3795



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)