You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/04/25 20:34:13 UTC

[GitHub] [systemml] mboehm7 commented on pull request #889: [SYSTEMML-2121] PCA test for codegenalg suite

mboehm7 commented on pull request #889:
URL: https://github.com/apache/systemml/pull/889#issuecomment-619437072


   LGTM - thanks @j143. During the merge, I fixed the sparsity configuration as all tests ran with the dense configuration. Furthermore, I cleaned up the test a bit (to use the util exec mode setup), reduced dimension sizes, and modified the PCA algorithm to use the now existing `scale` builtin function.
   
   In a subsequent change, I will rework the setup of codegen test configurations which has currently quite some redundancy across the different algorithms.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org