You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/04/23 00:29:06 UTC
Review Request 46590: GEODE-1237 remove the check for
network-partition-detection uniformity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46590/
-----------------------------------------------------------
Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
Repository: geode
Description
-------
Each member now determines whether to force shutdown due to loss of quorum. They also decide whether locators are preferred as membership coordinators. This primarily meant removing the method GMSJoinLeave.inheritSettingsFromLocator() but the ID settings needed to be made in other places (JGroupsMessenger.establishLocalAddress() and GMSJoinLeave.started()).
I also noticed that some of the code was still using "splitBrain" and "SB" instead of networkPartitionDetection and "NPD" and fixed that.
One test had to be removed from LocatorDUnitTest and a couple of others needed to be adjusted to have all of the members set network-partition-detection-enabled=true. Precheckin is running and I'll fix any other tests that have this problem.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java a5d269b1e59b451e30ca7e0400fdb8f2ccfc515c
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 81058f85b814be7387808b691e13b8c841148544
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetMember.java 43f3cf173e3cc5f941fc6ab9e1a3a20cd51c111a
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java 84ace6ce1826369be1cd94a4d3b98e02b93b6671
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/ServiceConfig.java 9f0bbf78fee922bc9d841cddaab71b2313aa53ab
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java c8b6aaae6b16c01b265674f2b5438f5adcb5edf4
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 05350e5e99a58b7dea7a60ba8da7d2699a348562
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java a9abea3b442612db467bd3b5a390ef955924cdba
geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java 8285a651b6e0285d14ea3f82b5eb73460bd6fa56
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 702a8592735456b07e05d46d5301043ed9f674f3
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveTestHelper.java bf13420b84206227230adc48165922d2126e6272
Diff: https://reviews.apache.org/r/46590/diff/
Testing
-------
Thanks,
Bruce Schuchardt
Re: Review Request 46590: GEODE-1237 remove the check for
network-partition-detection uniformity
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46590/#review130514
-----------------------------------------------------------
Ship it!
Ship It!
- Jianxia Chen
On April 22, 2016, 10:29 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46590/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 10:29 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Each member now determines whether to force shutdown due to loss of quorum. They also decide whether locators are preferred as membership coordinators. This primarily meant removing the method GMSJoinLeave.inheritSettingsFromLocator() but the ID settings needed to be made in other places (JGroupsMessenger.establishLocalAddress() and GMSJoinLeave.started()).
>
> I also noticed that some of the code was still using "splitBrain" and "SB" instead of networkPartitionDetection and "NPD" and fixed that.
>
> One test had to be removed from LocatorDUnitTest and a couple of others needed to be adjusted to have all of the members set network-partition-detection-enabled=true. Precheckin is running and I'll fix any other tests that have this problem.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java a5d269b1e59b451e30ca7e0400fdb8f2ccfc515c
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 81058f85b814be7387808b691e13b8c841148544
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetMember.java 43f3cf173e3cc5f941fc6ab9e1a3a20cd51c111a
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java 84ace6ce1826369be1cd94a4d3b98e02b93b6671
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/ServiceConfig.java 9f0bbf78fee922bc9d841cddaab71b2313aa53ab
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java c8b6aaae6b16c01b265674f2b5438f5adcb5edf4
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 05350e5e99a58b7dea7a60ba8da7d2699a348562
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java a9abea3b442612db467bd3b5a390ef955924cdba
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java 8285a651b6e0285d14ea3f82b5eb73460bd6fa56
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 702a8592735456b07e05d46d5301043ed9f674f3
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveTestHelper.java bf13420b84206227230adc48165922d2126e6272
>
> Diff: https://reviews.apache.org/r/46590/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 46590: GEODE-1237 remove the check for
network-partition-detection uniformity
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46590/#review130494
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On April 22, 2016, 10:29 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46590/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 10:29 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Each member now determines whether to force shutdown due to loss of quorum. They also decide whether locators are preferred as membership coordinators. This primarily meant removing the method GMSJoinLeave.inheritSettingsFromLocator() but the ID settings needed to be made in other places (JGroupsMessenger.establishLocalAddress() and GMSJoinLeave.started()).
>
> I also noticed that some of the code was still using "splitBrain" and "SB" instead of networkPartitionDetection and "NPD" and fixed that.
>
> One test had to be removed from LocatorDUnitTest and a couple of others needed to be adjusted to have all of the members set network-partition-detection-enabled=true. Precheckin is running and I'll fix any other tests that have this problem.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java a5d269b1e59b451e30ca7e0400fdb8f2ccfc515c
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 81058f85b814be7387808b691e13b8c841148544
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetMember.java 43f3cf173e3cc5f941fc6ab9e1a3a20cd51c111a
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java 84ace6ce1826369be1cd94a4d3b98e02b93b6671
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/ServiceConfig.java 9f0bbf78fee922bc9d841cddaab71b2313aa53ab
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java c8b6aaae6b16c01b265674f2b5438f5adcb5edf4
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 05350e5e99a58b7dea7a60ba8da7d2699a348562
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java a9abea3b442612db467bd3b5a390ef955924cdba
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java 8285a651b6e0285d14ea3f82b5eb73460bd6fa56
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 702a8592735456b07e05d46d5301043ed9f674f3
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveTestHelper.java bf13420b84206227230adc48165922d2126e6272
>
> Diff: https://reviews.apache.org/r/46590/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 46590: GEODE-1237 remove the check for
network-partition-detection uniformity
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46590/#review130459
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On April 22, 2016, 10:29 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46590/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 10:29 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Each member now determines whether to force shutdown due to loss of quorum. They also decide whether locators are preferred as membership coordinators. This primarily meant removing the method GMSJoinLeave.inheritSettingsFromLocator() but the ID settings needed to be made in other places (JGroupsMessenger.establishLocalAddress() and GMSJoinLeave.started()).
>
> I also noticed that some of the code was still using "splitBrain" and "SB" instead of networkPartitionDetection and "NPD" and fixed that.
>
> One test had to be removed from LocatorDUnitTest and a couple of others needed to be adjusted to have all of the members set network-partition-detection-enabled=true. Precheckin is running and I'll fix any other tests that have this problem.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java a5d269b1e59b451e30ca7e0400fdb8f2ccfc515c
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 81058f85b814be7387808b691e13b8c841148544
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetMember.java 43f3cf173e3cc5f941fc6ab9e1a3a20cd51c111a
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java 84ace6ce1826369be1cd94a4d3b98e02b93b6671
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/ServiceConfig.java 9f0bbf78fee922bc9d841cddaab71b2313aa53ab
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java c8b6aaae6b16c01b265674f2b5438f5adcb5edf4
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 05350e5e99a58b7dea7a60ba8da7d2699a348562
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java a9abea3b442612db467bd3b5a390ef955924cdba
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java 8285a651b6e0285d14ea3f82b5eb73460bd6fa56
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 702a8592735456b07e05d46d5301043ed9f674f3
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveTestHelper.java bf13420b84206227230adc48165922d2126e6272
>
> Diff: https://reviews.apache.org/r/46590/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>