You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/13 10:21:57 UTC

[GitHub] [shardingsphere] yu199195 opened a new pull request #7776: fix oracle table name must to upper

yu199195 opened a new pull request #7776:
URL: https://github.com/apache/shardingsphere/pull/7776


   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking closed pull request #7776: fix oracle table name must to upper

Posted by GitBox <gi...@apache.org>.
kimmking closed pull request #7776:
URL: https://github.com/apache/shardingsphere/pull/7776


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yu199195 commented on a change in pull request #7776: fix oracle table name must to upper

Posted by GitBox <gi...@apache.org>.
yu199195 commented on a change in pull request #7776:
URL: https://github.com/apache/shardingsphere/pull/7776#discussion_r504368591



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/model/physical/jdbc/handler/TableNamePatternHandler.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.metadata.model.physical.jdbc.handler;
+
+import org.apache.shardingsphere.infra.spi.typed.TypedSPI;
+
+/**
+ * Table name pattern handler.
+ */
+public interface TableNamePatternHandler extends TypedSPI {
+    
+    /**
+     * decorate table name pattern.

Review comment:
       modify already

##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/model/physical/jdbc/handler/TableNamePatternHandler.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.metadata.model.physical.jdbc.handler;
+
+import org.apache.shardingsphere.infra.spi.typed.TypedSPI;
+
+/**
+ * Table name pattern handler.
+ */
+public interface TableNamePatternHandler extends TypedSPI {
+    
+    /**
+     * decorate table name pattern.
+     * 
+     * @param tableNamePattern table name pattern
+     * @return decorate of table name pattern

Review comment:
       modify already




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #7776: fix oracle table name must to upper

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #7776:
URL: https://github.com/apache/shardingsphere/pull/7776#issuecomment-707821664


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=h1) Report
   > Merging [#7776](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7598c9a48718abd2e66f2de0960512d8af925657?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7776/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #7776   +/-   ##
   =========================================
     Coverage     74.98%   74.99%           
   - Complexity      524      525    +1     
   =========================================
     Files          1415     1417    +2     
     Lines         22538    22549   +11     
     Branches       4052     4051    -1     
   =========================================
   + Hits          16901    16911   +10     
   - Misses         4552     4553    +1     
     Partials       1085     1085           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...bc/handler/impl/OracleTableNamePatternHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9qZGJjL2hhbmRsZXIvaW1wbC9PcmFjbGVUYWJsZU5hbWVQYXR0ZXJuSGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...sical/model/table/PhysicalTableMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9tb2RlbC90YWJsZS9QaHlzaWNhbFRhYmxlTWV0YURhdGFMb2FkZXIuamF2YQ==) | `88.23% <100.00%> (+10.45%)` | `0.00 <0.00> (ø)` | |
   | [.../physical/model/schema/PhysicalSchemaMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9tb2RlbC9zY2hlbWEvUGh5c2ljYWxTY2hlbWFNZXRhRGF0YS5qYXZh) | `94.44% <0.00%> (-0.56%)` | `0.00% <0.00%> (ø%)` | |
   | [...aling/core/execute/executor/record/DataRecord.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL3JlY29yZC9EYXRhUmVjb3JkLmphdmE=) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...rser/sql/common/statement/dml/DeleteStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC9kbWwvRGVsZXRlU3RhdGVtZW50LmphdmE=) | `50.00% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | [...rser/sql/common/statement/dml/InsertStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC9kbWwvSW5zZXJ0U3RhdGVtZW50LmphdmE=) | `40.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...rser/sql/common/statement/dml/SelectStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC9kbWwvU2VsZWN0U3RhdGVtZW50LmphdmE=) | `25.00% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | [...rser/sql/common/statement/dml/UpdateStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC9kbWwvVXBkYXRlU3RhdGVtZW50LmphdmE=) | `50.00% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | [...er/sql/common/statement/ddl/TruncateStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC9kZGwvVHJ1bmNhdGVTdGF0ZW1lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...r/sql/common/statement/ddl/DropTableStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC9kZGwvRHJvcFRhYmxlU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [185 more](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=footer). Last update [7598c9a...d18e5af](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7776: fix oracle table name must to upper

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #7776:
URL: https://github.com/apache/shardingsphere/pull/7776#discussion_r504055119



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/model/physical/jdbc/handler/TableNamePatternHandler.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.metadata.model.physical.jdbc.handler;
+
+import org.apache.shardingsphere.infra.spi.typed.TypedSPI;
+
+/**
+ * Table name pattern handler.
+ */
+public interface TableNamePatternHandler extends TypedSPI {
+    
+    /**
+     * decorate table name pattern.
+     * 
+     * @param tableNamePattern table name pattern
+     * @return decorate of table name pattern

Review comment:
       The java doc `decorate of table name pattern` is not good sentence,
   It is better to revise it as `decorated table name pattern`

##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/model/physical/jdbc/handler/TableNamePatternHandler.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.metadata.model.physical.jdbc.handler;
+
+import org.apache.shardingsphere.infra.spi.typed.TypedSPI;
+
+/**
+ * Table name pattern handler.
+ */
+public interface TableNamePatternHandler extends TypedSPI {
+    
+    /**
+     * decorate table name pattern.

Review comment:
       Please upper case for first letter of java doc




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #7776: fix oracle table name must to upper

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7776:
URL: https://github.com/apache/shardingsphere/pull/7776#issuecomment-707821664


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=h1) Report
   > Merging [#7776](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7598c9a48718abd2e66f2de0960512d8af925657?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7776/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #7776   +/-   ##
   =========================================
     Coverage     74.98%   74.99%           
   - Complexity      524      525    +1     
   =========================================
     Files          1415     1416    +1     
     Lines         22538    22549   +11     
     Branches       4052     4052           
   =========================================
   + Hits          16901    16910    +9     
     Misses         4552     4552           
   - Partials       1085     1087    +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...bc/handler/impl/OracleTableNamePatternHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9qZGJjL2hhbmRsZXIvaW1wbC9PcmFjbGVUYWJsZU5hbWVQYXR0ZXJuSGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...sical/model/table/PhysicalTableMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9tb2RlbC90YWJsZS9QaHlzaWNhbFRhYmxlTWV0YURhdGFMb2FkZXIuamF2YQ==) | `88.23% <100.00%> (+10.45%)` | `0.00 <0.00> (ø)` | |
   | [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1jb3JlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
   | [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/7776/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `78.00% <0.00%> (-2.00%)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=footer). Last update [7598c9a...e8c24bd](https://codecov.io/gh/apache/shardingsphere/pull/7776?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #7776: fix oracle table name must to upper

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7776:
URL: https://github.com/apache/shardingsphere/pull/7776


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org