[jira] [Commented] (CLOUDSTACK-9162) Unable to add VPN user via API with Required Parameters

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055567#comment-15055567 ] 

ASF GitHub Bot commented on CLOUDSTACK-9162:
--------------------------------------------

GitHub user kansal opened a pull request:

    https://github.com/apache/cloudstack/pull/1241

    CLOUDSTACK-9162: Unable to add VPN user via API with Required Paramet…

    …ers - Fixed
    
    RCA:
    When we do not provide account parameter which is an optional field , API picks up the account from which we are logged in. So this works fine with cloudmonkey and ACS UI. But if we fire API directly from the browser(Make sure no cookies are stored and you are not logged in), by default system account is picked and the VPN users addition fails. This behaviour is expected, but no exception is thrown. So users think that VPN user is created.
    
    Fix: Added an exception when VPN users are added in the system account. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kansal/cloudstack CLOUDSTACK-9162

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1241
    
----
commit b8497b2a375b256a9f96ffaaaebd0829c88fd45c
Author: Kshitij Kansal <ka...@gmail.com>
Date:   2015-12-14T07:16:40Z

    CLOUDSTACK-9162: Unable to add VPN user via API with Required Parameters - Fixed

----


> Unable to add VPN user via API with Required Parameters
> -------------------------------------------------------
>
>                 Key: CLOUDSTACK-9162
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9162
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Kshitij Kansal
>            Assignee: Kshitij Kansal
>
> With the following API request 127.0.0.1:8096/client/api?command=addVpnUser&password=password111&username=api123 VPN user fails with following reason : Failed to apply vpn for user api123, accountId=1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)