You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Maron <jm...@hortonworks.com> on 2015/04/29 23:37:38 UTC
Review Request 33698: Initial service definition for Apache Atlas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
Repository: ambari
Description
-------
This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
Diffs
-----
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
Diff: https://reviews.apache.org/r/33698/diff/
Testing
-------
Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
Thanks,
Jonathan Maron
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py, line 33
> > <https://reviews.apache.org/r/33698/diff/1/?file=945758#file945758line33>
> >
> > Security needs to be accounted for, i.e., kinit in start and stop commands.
>
> Jonathan Maron wrote:
> As indicated in the description, I was hoping to tackle the security requirements once we were satisfied and committed an initial service definition.
Is there a Jira for it already?
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82054
-----------------------------------------------------------
On April 30, 2015, 10:04 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 10:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py, line 37
> > <https://reviews.apache.org/r/33698/diff/1/?file=945757#file945757line37>
> >
> > This is not always the case, need it to be [200, 300)
>
> Jonathan Maron wrote:
> I can make it 200, but I would imagine a response less that 400 is sufficient to indicate liveness?
300-307 are things like redirect
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82054
-----------------------------------------------------------
On April 30, 2015, 10:04 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 10:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jonathan Maron <jm...@hortonworks.com>.
> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py, line 21
> > <https://reviews.apache.org/r/33698/diff/1/?file=945754#file945754line21>
> >
> > Use named imports
>
> Jonathan Maron wrote:
> I've spent about the last 3 hours trying to narrow down the imports. The limited set appears to be:
>
> from metadata import metadata
> from resource_management import Execute, check_process_status, Script
>
> However, I can no longer pass the unit tests:
>
> Traceback (most recent call last):
> File "/Users/jmaron/dev/workspaces/ambari/ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py", line 107, in test_start_default
> user = 'atlas',
> File "/Users/jmaron/dev/workspaces/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 233, in assertResourceCalled
> self.assertEquals(name, resource.name)
> AssertionError: 'source /etc/atlas/conf/metadata-env.sh ; /usr/hdp/current/atlas-server/bin/metadata-start.sh --port 21000' != 'source {params.conf_dir}/metadata-env.sh ; {params.metadata_start_script} --port {params.metadata_port}'
>
> If I change it back to 'from resource management import *' the unit tests once again pass.
>
> Do you happen to know the less than obvious import(s) I am missing? I am checking against other service scripts, but most seem to be importinb '*'
never mind, figured it out. had to import format from resource_management.libraries.functions
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82054
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jonathan Maron <jm...@hortonworks.com>.
> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py, line 21
> > <https://reviews.apache.org/r/33698/diff/1/?file=945754#file945754line21>
> >
> > Use named imports
I've spent about the last 3 hours trying to narrow down the imports. The limited set appears to be:
from metadata import metadata
from resource_management import Execute, check_process_status, Script
However, I can no longer pass the unit tests:
Traceback (most recent call last):
File "/Users/jmaron/dev/workspaces/ambari/ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py", line 107, in test_start_default
user = 'atlas',
File "/Users/jmaron/dev/workspaces/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 233, in assertResourceCalled
self.assertEquals(name, resource.name)
AssertionError: 'source /etc/atlas/conf/metadata-env.sh ; /usr/hdp/current/atlas-server/bin/metadata-start.sh --port 21000' != 'source {params.conf_dir}/metadata-env.sh ; {params.metadata_start_script} --port {params.metadata_port}'
If I change it back to 'from resource management import *' the unit tests once again pass.
Do you happen to know the less than obvious import(s) I am missing? I am checking against other service scripts, but most seem to be importinb '*'
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82054
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py, line 37
> > <https://reviews.apache.org/r/33698/diff/1/?file=945754#file945754line37>
> >
> > Will eventually need it to be included in RU.
> > So it will need its definition in upgrade-2.3.xml
>
> Jonathan Maron wrote:
> Is this an immediate need, or do you mean at some later point?
>
> Alejandro Fernandez wrote:
> Rolling Upgrade will fail without it, so I would say it's a requirement, or at minimum a Jira. For now, you can set versionAdvertised = false in metainfo.xml
>
> Jonathan Maron wrote:
> will that prevent an upgrade failure for the time being?
correct Jonathan. The component will not be checked during Finalize.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82054
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jonathan Maron <jm...@hortonworks.com>.
> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py, line 37
> > <https://reviews.apache.org/r/33698/diff/1/?file=945754#file945754line37>
> >
> > Will eventually need it to be included in RU.
> > So it will need its definition in upgrade-2.3.xml
>
> Jonathan Maron wrote:
> Is this an immediate need, or do you mean at some later point?
>
> Alejandro Fernandez wrote:
> Rolling Upgrade will fail without it, so I would say it's a requirement, or at minimum a Jira. For now, you can set versionAdvertised = false in metainfo.xml
will that prevent an upgrade failure for the time being?
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82054
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jonathan Maron <jm...@hortonworks.com>.
> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml, line 32
> > <https://reviews.apache.org/r/33698/diff/1/?file=945752#file945752line32>
> >
> > Does Atlas have a component name in hdp-select? E.g., hdp-select status atlas
yes - I merged in an additional leaf yesterday.
> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py, line 37
> > <https://reviews.apache.org/r/33698/diff/1/?file=945754#file945754line37>
> >
> > Will eventually need it to be included in RU.
> > So it will need its definition in upgrade-2.3.xml
Is this an immediate need, or do you mean at some later point?
> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py, line 37
> > <https://reviews.apache.org/r/33698/diff/1/?file=945757#file945757line37>
> >
> > This is not always the case, need it to be [200, 300)
I can make it 200, but I would imagine a response less that 400 is sufficient to indicate liveness?
> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py, line 33
> > <https://reviews.apache.org/r/33698/diff/1/?file=945758#file945758line33>
> >
> > Security needs to be accounted for, i.e., kinit in start and stop commands.
As indicated in the description, I was hoping to tackle the security requirements once we were satisfied and committed an initial service definition.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82054
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py, line 37
> > <https://reviews.apache.org/r/33698/diff/1/?file=945754#file945754line37>
> >
> > Will eventually need it to be included in RU.
> > So it will need its definition in upgrade-2.3.xml
>
> Jonathan Maron wrote:
> Is this an immediate need, or do you mean at some later point?
Rolling Upgrade will fail without it, so I would say it's a requirement, or at minimum a Jira. For now, you can set versionAdvertised = false in metainfo.xml
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82054
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jonathan Maron <jm...@hortonworks.com>.
> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py, line 37
> > <https://reviews.apache.org/r/33698/diff/1/?file=945757#file945757line37>
> >
> > This is not always the case, need it to be [200, 300)
>
> Jonathan Maron wrote:
> I can make it 200, but I would imagine a response less that 400 is sufficient to indicate liveness?
>
> Alejandro Fernandez wrote:
> 300-307 are things like redirect
I think those still indicate that the server is up and responding. However, let me know if you insist on this change - I'm not unreasonable ;)
> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py, line 33
> > <https://reviews.apache.org/r/33698/diff/1/?file=945758#file945758line33>
> >
> > Security needs to be accounted for, i.e., kinit in start and stop commands.
>
> Jonathan Maron wrote:
> As indicated in the description, I was hoping to tackle the security requirements once we were satisfied and committed an initial service definition.
>
> Alejandro Fernandez wrote:
> Is there a Jira for it already?
Not yet. I was waiting to see if this approach (following initial commit with subsequent one for security etc) is approved by the reviewers.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82054
-----------------------------------------------------------
On April 30, 2015, 10:04 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 10:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82054
-----------------------------------------------------------
Thanks for writing unit tests!
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml
<https://reviews.apache.org/r/33698/#comment132696>
Does Atlas have a component name in hdp-select? E.g., hdp-select status atlas
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py
<https://reviews.apache.org/r/33698/#comment132697>
Used name imports since it's easier to debug
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py
<https://reviews.apache.org/r/33698/#comment132698>
sys and deepcopy are not used
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py
<https://reviews.apache.org/r/33698/#comment132699>
Use named imports
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py
<https://reviews.apache.org/r/33698/#comment132700>
Will eventually need it to be included in RU.
So it will need its definition in upgrade-2.3.xml
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py
<https://reviews.apache.org/r/33698/#comment132701>
Use named imports
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py
<https://reviews.apache.org/r/33698/#comment132703>
Use named imports.
regex is not used here.
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py
<https://reviews.apache.org/r/33698/#comment132702>
Use named imports
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py
<https://reviews.apache.org/r/33698/#comment132704>
This is not always the case, need it to be [200, 300)
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py
<https://reviews.apache.org/r/33698/#comment132705>
Use named imports
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py
<https://reviews.apache.org/r/33698/#comment132706>
Security needs to be accounted for, i.e., kinit in start and stop commands.
- Alejandro Fernandez
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On April 29, 2015, 10:03 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml, line 21
> > <https://reviews.apache.org/r/33698/diff/1/?file=945749#file945749line21>
> >
> > You have this file. So you can add one more entry for content and use that as template.
>
> Jonathan Maron wrote:
> Is that a necessary change or simply a style change? i.e. is it a blocker? ;)
Without that the file will not be completely configurable. Configurability will be limited to the properties in the XML file only. In general, Ambari does not want to limit configurability.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82037
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jonathan Maron <jm...@hortonworks.com>.
> On April 29, 2015, 10:03 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml, line 21
> > <https://reviews.apache.org/r/33698/diff/1/?file=945749#file945749line21>
> >
> > You have this file. So you can add one more entry for content and use that as template.
Is that a necessary change or simply a style change? i.e. is it a blocker? ;)
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82037
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82037
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml
<https://reviews.apache.org/r/33698/#comment132664>
You have this file. So you can add one more entry for content and use that as template.
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2
<https://reviews.apache.org/r/33698/#comment132663>
Same comment as for the log4j file.
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2
<https://reviews.apache.org/r/33698/#comment132662>
Can you move it to configuration - similar to ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-log4j.xml. That way, it will be editable on Ambari UI.
- Sumit Mohanty
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On April 29, 2015, 10:06 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py, line 1
> > <https://reviews.apache.org/r/33698/diff/1/?file=945755#file945755line1>
> >
> > Is there a linux vs. windows story for Atlas? Or, is it linux only?
>
> Jonathan Maron wrote:
> Without the existence of an MSI, is a windows installation via ambari even an option?
Windows support can also be postponed to a later patch. Yes, you would need ATLAS to be part of the MSI for the installation to work.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82046
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jonathan Maron <jm...@hortonworks.com>.
> On April 29, 2015, 10:06 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py, line 1
> > <https://reviews.apache.org/r/33698/diff/1/?file=945755#file945755line1>
> >
> > Is there a linux vs. windows story for Atlas? Or, is it linux only?
>
> Jonathan Maron wrote:
> Without the existence of an MSI, is a windows installation via ambari even an option?
>
> Sumit Mohanty wrote:
> Windows support can also be postponed to a later patch. Yes, you would need ATLAS to be part of the MSI for the installation to work.
OK. I migrated the scripts to leverage the python scripts as a step towards a windows capability.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82046
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jonathan Maron <jm...@hortonworks.com>.
> On April 29, 2015, 10:06 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py, line 1
> > <https://reviews.apache.org/r/33698/diff/1/?file=945755#file945755line1>
> >
> > Is there a linux vs. windows story for Atlas? Or, is it linux only?
Without the existence of an MSI, is a windows installation via ambari even an option?
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82046
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82046
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py
<https://reviews.apache.org/r/33698/#comment132681>
Is there a linux vs. windows story for Atlas? Or, is it linux only?
- Sumit Mohanty
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On April 29, 2015, 10:53 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json, line 3
> > <https://reviews.apache.org/r/33698/diff/1/?file=945748#file945748line3>
> >
> > Any service level alerts required?
>
> Jonathan Maron wrote:
> I'd like to tackle alerts in a subsequent commit. I am unfamiliar with the mechanism and would prefer to get a working, basic service definition committed at this time.
Sounds good. For alerts you can work with Nate Cole and Jonathan Hurley.
> On April 29, 2015, 10:53 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py, line 1
> > <https://reviews.apache.org/r/33698/diff/1/?file=945755#file945755line1>
> >
> > +1 on this. Whats the story for Windows?
>
> Jonathan Maron wrote:
> We do have windows python scripts. I was under the impression that ambari did not yet support windows. I'd have to check if windows support via Ambari is an initial requirement.
Ambari support for Windows is under development. Jonathan, we can sync up offline on it.
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82050
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jonathan Maron <jm...@hortonworks.com>.
> On April 29, 2015, 10:53 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json, line 3
> > <https://reviews.apache.org/r/33698/diff/1/?file=945748#file945748line3>
> >
> > Any service level alerts required?
I'd like to tackle alerts in a subsequent commit. I am unfamiliar with the mechanism and would prefer to get a working, basic service definition committed at this time.
> On April 29, 2015, 10:53 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py, line 1
> > <https://reviews.apache.org/r/33698/diff/1/?file=945755#file945755line1>
> >
> > +1 on this. Whats the story for Windows?
We do have windows python scripts. I was under the impression that ambari did not yet support windows. I'd have to check if windows support via Ambari is an initial requirement.
> On April 29, 2015, 10:53 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json, line 9
> > <https://reviews.apache.org/r/33698/diff/1/?file=945761#file945761line9>
> >
> > Are there any dependencies on other services?
No
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82050
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82050
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json
<https://reviews.apache.org/r/33698/#comment132690>
FALCON?
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json
<https://reviews.apache.org/r/33698/#comment132693>
Any service level alerts required?
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py
<https://reviews.apache.org/r/33698/#comment132691>
+1 on this. Whats the story for Windows?
ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json
<https://reviews.apache.org/r/33698/#comment132692>
Are there any dependencies on other services?
- Jayush Luniya
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jonathan Maron <jm...@hortonworks.com>.
> On April 30, 2015, 10:22 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py, line 50
> > <https://reviews.apache.org/r/33698/diff/2/?file=946481#file946481line50>
> >
> > It's a one-liner, let's go a head change it. Thanks!
OK. I'll make the change. Can I proceed with a commit/push after that change?
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82212
-----------------------------------------------------------
On April 30, 2015, 10:04 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 10:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On April 30, 2015, 10:22 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py, line 50
> > <https://reviews.apache.org/r/33698/diff/2/?file=946481#file946481line50>
> >
> > It's a one-liner, let's go a head change it. Thanks!
>
> Jonathan Maron wrote:
> OK. I'll make the change. Can I proceed with a commit/push after that change?
Yes
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82212
-----------------------------------------------------------
On May 1, 2015, 2:24 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 2:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82212
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py
<https://reviews.apache.org/r/33698/#comment132912>
It's a one-liner, let's go a head change it. Thanks!
- Alejandro Fernandez
On April 30, 2015, 10:04 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 10:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On April 30, 2015, 10:30 p.m., Jonathan Maron wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py, line 50
> > <https://reviews.apache.org/r/33698/diff/2/?file=946481#file946481line50>
> >
> > Just to be clear: you want the line to specifically check for 200 (status == 200)?
That's up to the service to define, as long as it's in the range [200, 300)
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82213
-----------------------------------------------------------
On April 30, 2015, 10:04 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 10:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jonathan Maron <jm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82213
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py
<https://reviews.apache.org/r/33698/#comment132913>
Just to be clear: you want the line to specifically check for 200 (status == 200)?
- Jonathan Maron
On April 30, 2015, 10:04 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 10:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review83002
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json
<https://reviews.apache.org/r/33698/#comment133880>
This isn't hurting anything, but since there is only one component and it already references (and modifies) the `/spnego` identitiy, there is no need for the service-level declaration.
If there were multiple components and at least one didn't have any modifications for the base identities, than the service-level declaration would be needed.
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py
<https://reviews.apache.org/r/33698/#comment133881>
This class should have a `security_status` method to report back to Ambari whether it is properly configured for Kerberos or not. See common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py:80 for example.
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py
<https://reviews.apache.org/r/33698/#comment133882>
get_kinit_path should be called with the user-declared search paths:
```
kinit_path_local = get_kinit_path(default('/configurations/kerberos-env/executable_search_paths', None))
```
Is this even used? Actually it may be if `security_status` is implemented in the lifecycle script.
- Robert Levas
On May 1, 2015, 10:24 a.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 10:24 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82250
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On May 1, 2015, 2:24 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 2:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jonathan Maron <jm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/
-----------------------------------------------------------
(Updated May 1, 2015, 2:24 p.m.)
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
Changes
-------
Updated the service check to explicitly check for expected 200 status response.
Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
Repository: ambari
Description
-------
This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
Diff: https://reviews.apache.org/r/33698/diff/
Testing
-------
Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
Thanks,
Jonathan Maron
Re: Review Request 33698: Initial service definition for Apache Atlas
Posted by Jonathan Maron <jm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/
-----------------------------------------------------------
(Updated April 30, 2015, 10:04 p.m.)
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
Changes
-------
I've responded to most of the current review comments:
- the imports are specific/named
- I've removed the jinja templates and used inline templates instead
- set versionAdvertised to false in metainfo.xml
- Atlas is currently not even included in the HDP MSI and it's unclear whether it will be. For now I've migrated to using python scripts instead of shell scrips (though still using metadata-env.sh)
- I'd like to tackle security, metrics, rolling upgrades, windows, and UI enhancements as subsequent JIRAs.
Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
Repository: ambari
Description
-------
This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting:
1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder).
2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested)
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128
ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION
ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
Diff: https://reviews.apache.org/r/33698/diff/
Testing
-------
Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written.
Thanks,
Jonathan Maron