You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streampipes.apache.org by ri...@apache.org on 2023/03/08 21:31:02 UTC

[streampipes] 01/02: Properly handle booleans with value false in data explorer filter (#1391)

This is an automated email from the ASF dual-hosted git repository.

riemer pushed a commit to branch 1391-data-explorer-filter-doesnt-work-for-boolean-and-false-value
in repository https://gitbox.apache.org/repos/asf/streampipes.git

commit e9224798118beeb3d3c9873b24352f15a4872ba3
Author: Dominik Riemer <do...@gmail.com>
AuthorDate: Wed Mar 8 22:26:19 2023 +0100

    Properly handle booleans with value false in data explorer filter (#1391)
---
 .../streampipes/dataexplorer/v4/params/WhereStatementParams.java     | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/streampipes-data-explorer/src/main/java/org/apache/streampipes/dataexplorer/v4/params/WhereStatementParams.java b/streampipes-data-explorer/src/main/java/org/apache/streampipes/dataexplorer/v4/params/WhereStatementParams.java
index b5ddcf16d..0c7f1829c 100644
--- a/streampipes-data-explorer/src/main/java/org/apache/streampipes/dataexplorer/v4/params/WhereStatementParams.java
+++ b/streampipes-data-explorer/src/main/java/org/apache/streampipes/dataexplorer/v4/params/WhereStatementParams.java
@@ -103,14 +103,17 @@ public class WhereStatementParams extends QueryParamsV4 {
   }
 
   private String returnCondition(String inputCondition) {
-    if (NumberUtils.isCreatable(inputCondition) || Boolean.parseBoolean(inputCondition)) {
+    if (NumberUtils.isCreatable(inputCondition) || isBoolean(inputCondition)) {
       return inputCondition;
     } else if (inputCondition.equals("\"\"")) {
       return inputCondition;
     } else {
       return "'" + inputCondition + "'";
     }
+  }
 
+  private boolean isBoolean(String input) {
+    return "true".equalsIgnoreCase(input) || "false".equalsIgnoreCase(input);
   }
 
   public List<WhereCondition> getWhereConditions() {