You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "TeFuirnever (via GitHub)" <gi...@apache.org> on 2024/07/31 16:29:32 UTC
[PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]
TeFuirnever opened a new pull request, #8477:
URL: https://github.com/apache/rocketmq/pull/8477
### Which Issue(s) This PR Fixes
[Enhancement] Add test cases for org.apache.rocketmq.common.attribute #8476
Fixes #8476
### Brief Description
Add more test coverage for Add test cases for org.apache.rocketmq.common.attribute.
### How Did You Test This Change?
run test case successfull.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]
Posted by "TeFuirnever (via GitHub)" <gi...@apache.org>.
TeFuirnever commented on PR #8477:
URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2263505769
> > I see a lot of people having this problem, what can be done to fix it?
>
> This bazel-build check isn't 'required' for pr merging, but u can try to fix these flaky tests if you are interested in this question.
Got it, thanks a lot!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]
Posted by "TeFuirnever (via GitHub)" <gi...@apache.org>.
TeFuirnever commented on PR #8477:
URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2263476449
> Hello, is there something wrong with this test item（Build and Run Tests by Bazel / bazel-compile (ubuntu-latest) (pull_request)）? 
I've seen what appears to be a lot of people having this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]
Posted by "TeFuirnever (via GitHub)" <gi...@apache.org>.
TeFuirnever closed pull request #8477: [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute
URL: https://github.com/apache/rocketmq/pull/8477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]
Posted by "TeFuirnever (via GitHub)" <gi...@apache.org>.
TeFuirnever commented on PR #8477:
URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2265817027
> @TeFuirnever A reminder from the Tianchi platform: it‘s better to submit your results to the [official website](https://tianchi.aliyun.com/competition/entrance/532215/information) asap.
Got it, thanks so much! It was a great event!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]
Posted by "TeFuirnever (via GitHub)" <gi...@apache.org>.
TeFuirnever commented on PR #8477:
URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2260917046
for soc in https://github.com/apache/rocketmq/issues/8262 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]
Posted by "ShannonDing (via GitHub)" <gi...@apache.org>.
ShannonDing merged PR #8477:
URL: https://github.com/apache/rocketmq/pull/8477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]
Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on PR #8477:
URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2263489363
> I see a lot of people having this problem, what can be done to fix it?
This bazel-build check isn't 'required' for pr merging, but u can try to fix these flaky tests if you are interested in this question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]
Posted by "TeFuirnever (via GitHub)" <gi...@apache.org>.
TeFuirnever commented on PR #8477:
URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2265840190
Hello, how about merged the code, I'm going to move on to other UT tests.
@ShannonDing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]
Posted by "ShannonDing (via GitHub)" <gi...@apache.org>.
ShannonDing commented on PR #8477:
URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2264390168
@TeFuirnever A reminder from the Tianchi platform: it‘s better to submit your results to the [official website](https://tianchi.aliyun.com/competition/entrance/532215/information) asap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]
Posted by "TeFuirnever (via GitHub)" <gi...@apache.org>.
TeFuirnever commented on PR #8477:
URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2263479243
I see a lot of people having this problem, what can be done to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8477:
URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2260965730
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 46.05%. Comparing base [(`304987d`)](https://app.codecov.io/gh/apache/rocketmq/commit/304987d341f17f00e88a4ef2396f04950b4e1720?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`1d2d672`)](https://app.codecov.io/gh/apache/rocketmq/commit/1d2d672d3ec416c4b12e821c586801610ce3a360?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 8 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #8477 +/- ##
=============================================
+ Coverage 45.92% 46.05% +0.12%
- Complexity 11104 11161 +57
=============================================
Files 1274 1274
Lines 89001 89000 -1
Branches 11441 11443 +2
=============================================
+ Hits 40875 40990 +115
+ Misses 43027 42889 -138
- Partials 5099 5121 +22
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8477?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]
Posted by "TeFuirnever (via GitHub)" <gi...@apache.org>.
TeFuirnever commented on PR #8477:
URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2263475260
Hello, is there something wrong with this test item（Build and Run Tests by Bazel / bazel-compile (ubuntu-latest) (pull_request)）?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org