You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/06/21 15:08:07 UTC
Review Request 70922: Added master minimum capability for agent
draining.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70922/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.
Bugs: MESOS-9814
https://issues.apache.org/jira/browse/MESOS-9814
Repository: mesos
Description
-------
This adds a new enum for the agent draining feature in the master.
When an agent is marked for draining or deactivation, an associated
entry will be added to the master's registry. This will prevent
any master downgrades until all agents are reactivated.
Diffs
-----
docs/downgrades.md 08200015d8b533640b4656c88b0510cf41a7ffa4
include/mesos/mesos.proto 2b4f350815935220c2d2b0dd0e52346bc74c91d9
include/mesos/v1/mesos.proto bafc27499f810791700c4a30dcb1da33b6f31d2e
src/common/protobuf_utils.hpp ecaf8ea36c486b859870fe53e834e0844e317182
src/master/constants.cpp 1109b483daad10560e6d2c717a80492eddb507fc
Diff: https://reviews.apache.org/r/70922/diff/1/
Testing
-------
TODO: Need to look at this on a browser.
Thanks,
Joseph Wu
Re: Review Request 70922: Added master minimum capability for agent
draining.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70922/#review216101
-----------------------------------------------------------
Fix it, then Ship it!
docs/downgrades.md
Lines 33-34 (patched)
<https://reviews.apache.org/r/70922/#comment303091>
I find this a bit confusing. How about:
This capability is required when any agent of the master is marked for draining or deactivated.
- Meng Zhu
On June 21, 2019, 8:08 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70922/
> -----------------------------------------------------------
>
> (Updated June 21, 2019, 8:08 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, Meng Zhu, and Vinod Kone.
>
>
> Bugs: MESOS-9814
> https://issues.apache.org/jira/browse/MESOS-9814
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new enum for the agent draining feature in the master.
> When an agent is marked for draining or deactivation, an associated
> entry will be added to the master's registry. This will prevent
> any master downgrades until all agents are reactivated.
>
>
> Diffs
> -----
>
> docs/downgrades.md 08200015d8b533640b4656c88b0510cf41a7ffa4
> include/mesos/mesos.proto 2b4f350815935220c2d2b0dd0e52346bc74c91d9
> include/mesos/v1/mesos.proto bafc27499f810791700c4a30dcb1da33b6f31d2e
> src/common/protobuf_utils.hpp ecaf8ea36c486b859870fe53e834e0844e317182
> src/master/constants.cpp 1109b483daad10560e6d2c717a80492eddb507fc
> src/tests/master_tests.cpp 097f1b77a59e29c6690210773d1556ebf2bb701e
>
>
> Diff: https://reviews.apache.org/r/70922/diff/2/
>
>
> Testing
> -------
>
> TODO: Need to look at this on a browser.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 70922: Added master minimum capability for agent
draining.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70922/#review216059
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/master_tests.cpp
Line 5035 (original), 5035 (patched)
<https://reviews.apache.org/r/70922/#comment303034>
s/the some/these/
- Greg Mann
On June 21, 2019, 3:08 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70922/
> -----------------------------------------------------------
>
> (Updated June 21, 2019, 3:08 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, Meng Zhu, and Vinod Kone.
>
>
> Bugs: MESOS-9814
> https://issues.apache.org/jira/browse/MESOS-9814
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new enum for the agent draining feature in the master.
> When an agent is marked for draining or deactivation, an associated
> entry will be added to the master's registry. This will prevent
> any master downgrades until all agents are reactivated.
>
>
> Diffs
> -----
>
> docs/downgrades.md 08200015d8b533640b4656c88b0510cf41a7ffa4
> include/mesos/mesos.proto 2b4f350815935220c2d2b0dd0e52346bc74c91d9
> include/mesos/v1/mesos.proto bafc27499f810791700c4a30dcb1da33b6f31d2e
> src/common/protobuf_utils.hpp ecaf8ea36c486b859870fe53e834e0844e317182
> src/master/constants.cpp 1109b483daad10560e6d2c717a80492eddb507fc
> src/tests/master_tests.cpp 097f1b77a59e29c6690210773d1556ebf2bb701e
>
>
> Diff: https://reviews.apache.org/r/70922/diff/2/
>
>
> Testing
> -------
>
> TODO: Need to look at this on a browser.
>
>
> Thanks,
>
> Joseph Wu
>
>