You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@apr.apache.org by bu...@apache.org on 2022/06/15 09:41:21 UTC

[Bug 66121] New: CMake MSVC build fails on 1.8.x branch - apr_socket_pipe link issue

https://bz.apache.org/bugzilla/show_bug.cgi?id=66121

            Bug ID: 66121
           Summary: CMake MSVC build fails on 1.8.x branch -
                    apr_socket_pipe link issue
           Product: APR
           Version: HEAD
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: APR
          Assignee: bugs@apr.apache.org
          Reporter: bz.apache@nono303.net
  Target Milestone: ---

Hi,
on Revision 1901932 for /apr/apr/branches/1.8.x
 > Merge r1897895 from trunk
CMake MSVC build fails with error:

Creating library .\x64\Release\libapr-1.lib and object
.\x64\Release\libapr-1.exp
wakeup.obj : error LNK2001: unresolved external symbol apr_socket_pipe_close
wakeup.obj : error LNK2001: unresolved external symbol apr_socket_pipe_create
.\x64\Release\libapr-1.dll : fatal error LNK1120: 2 unresolved externals

Here are my check & to qualify it:
 - network_io/win32/socket_pipe.c & poll/unix/wakeup.c are present in
CMakeLists.txt and compiled without errors before linking
 - include/arch/win32/apr_arch_networkio.h define as extern
apr_socket_pipe_create & apr_socket_pipe_close
 - poll/unix/wakeup.c include apr_arch_networkio.h
 - include/apr_networkio.h does NOT mention apr_socket_pipe_create &
apr_socket_pipe_close

Any idea to fix this linking issue? (APR_DECLARE or public header export
missing...)
Thx!

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 66121] CMake MSVC build fails on 1.8.x branch - apr_socket_pipe link issue

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66121

--- Comment #1 from nono303 <bz...@nono303.net> ---
Created attachment 38328
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=38328&action=edit
fix missing socket_pipe.obj in apr.mak & libapr.mak

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 66121] CMake MSVC build fails on 1.8.x branch - apr_socket_pipe link issue

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66121

--- Comment #4 from nono303 <bz...@nono303.net> ---
Sounds good, Thx!

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 66121] CMake MSVC build fails on 1.8.x branch - apr_socket_pipe link issue

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66121

nono303 <bz...@nono303.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 OS|                            |All
         Resolution|---                         |INFORMATIONPROVIDED

--- Comment #2 from nono303 <bz...@nono303.net> ---
Hi,
Found the issue:
network_io/win32/socket_pipe.c was correctly added to 
CMakeLists.txt but not to apr.mak and libapr.mak
See attached a proposed patch fixing it
Might be other Win build files to update...

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 66121] CMake MSVC build fails on 1.8.x branch - apr_socket_pipe link issue

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66121

nono303 <bz...@nono303.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|All                         |Windows 10

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 66121] CMake MSVC build fails on 1.8.x branch - apr_socket_pipe link issue

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66121

ivan@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All
         Resolution|INFORMATIONPROVIDED         |FIXED

--- Comment #3 from ivan@apache.org ---
Committed tweaked patch in r1902576.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org