[jira] [Commented] (TINKERPOP-1469) Get rid of Stream-usage in TraversalHelper

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565324#comment-15565324 ] 

ASF GitHub Bot commented on TINKERPOP-1469:
-------------------------------------------

GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/454

    TINKERPOP-1469: Get rid of Stream-usage in TraversalHelper

    https://issues.apache.org/jira/browse/TINKERPOP-1469
    
    I went through `TraversalHelper` and removed all usage of `stream()` as well as added various other little nick-nack optimizations along the way.
    I also added some more test cases to `TraversalHelperTest`.
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1469

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/454.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #454
    
----
commit 9ce3fe86979a5f3452bfcb82ed8642fa1ea291c6
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2016-10-11T12:36:39Z

    removed stream()-usage and unneeded method recurssions in TraversalHelper.

commit 54226cde46b5b96cf756f1b4fb8dc40086c14aec
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2016-10-11T12:44:02Z

    added another test case for getLabels().

----


> Get rid of Stream-usage in TraversalHelper
> ------------------------------------------
>
>                 Key: TINKERPOP-1469
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1469
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.2
>            Reporter: Marko A. Rodriguez
>            Assignee: Marko A. Rodriguez
>
> There are lots of {{Stream}}-usages in {{TraversalHelper}}. Given that {{TraversalHelper}} is used extensively in the various traversal strategies (thus, compile time), it would be good to gut such stream usage to make things as efficient as possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)