You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/03 06:23:37 UTC
[GitHub] [airflow] tirkarthi opened a new pull request, #23440: Add fields to dagrun endpoint
tirkarthi opened a new pull request, #23440:
URL: https://github.com/apache/airflow/pull/23440
Add below fields to dagrun endpoint :
* data_interval_start
* data_interval_end
* last_scheduling_decision
* run_type
closes: #23415
related: #23415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tirkarthi commented on a diff in pull request #23440: Add fields to dagrun endpoint
Posted by GitBox <gi...@apache.org>.
tirkarthi commented on code in PR #23440:
URL: https://github.com/apache/airflow/pull/23440#discussion_r863513040
##########
tests/api_connexion/endpoints/test_dag_run_endpoint.py:
##########
@@ -1046,6 +1094,10 @@ def test_should_response_200_for_matching_execution_date_logical_date(self):
"external_trigger": True,
"start_date": None,
"state": "queued",
+ "data_interval_end": "2020-11-10T08:25:56.939143+00:00",
+ "data_interval_start": "2020-11-10T08:25:56.939143+00:00",
Review Comment:
Thanks @ephraimbuddy, made this one and another test to use constants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23440: Add fields to dagrun endpoint
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23440:
URL: https://github.com/apache/airflow/pull/23440#issuecomment-1115801502
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #23440: Add fields to dagrun endpoint
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #23440:
URL: https://github.com/apache/airflow/pull/23440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #23440: Add fields to dagrun endpoint
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on code in PR #23440:
URL: https://github.com/apache/airflow/pull/23440#discussion_r863507708
##########
tests/api_connexion/endpoints/test_dag_run_endpoint.py:
##########
@@ -1046,6 +1094,10 @@ def test_should_response_200_for_matching_execution_date_logical_date(self):
"external_trigger": True,
"start_date": None,
"state": "queued",
+ "data_interval_end": "2020-11-10T08:25:56.939143+00:00",
+ "data_interval_start": "2020-11-10T08:25:56.939143+00:00",
Review Comment:
Should we use this opportunity to refactor these hardcoded dates? We could have `logical_date` and `execution_date` as constants and pass them instead of these dates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org