You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2018/04/30 05:08:06 UTC
[GitHub] guacamole-client pull request #279: GUACAMOLE-526: Invoke logout() for the c...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/guacamole-client/pull/279
GUACAMOLE-526: Invoke logout() for the cached token BEFORE storing new token.
The changes introduced via #278 incorrectly invalidate the cached auth token after having already updated it with the new auth result. This causes the user to be logged out immediately after logging in if they happen to have a stale auth token.
To reproduce the above:
1. Log into Guacamole and allow the session to expire *OR* manually set `GUAC_AUTH` within `localStorage` to an auth result that contains an old/invalid token.
2. Visit any page within Guacamole. As your token is invalid, the login screen should display.
3. Log in with correct credentials. Though login succeeds, you will be immediately logged out and kicked back to a login screen.
These changes correct the order in which the old token is invalidated and the new token is stored.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/guacamole-client fix-auto-logout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-client/pull/279.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #279
----
commit 089113c35264172531c2a9d05542a58c4c2542c4
Author: Michael Jumper <mj...@...>
Date: 2018-04-30T05:01:32Z
GUACAMOLE-526: Invoke logout() for the cached token BEFORE storing the new token. The logout() call erroneously invalidates the new token otherwise.
----
---
[GitHub] guacamole-client pull request #279: GUACAMOLE-526: Invoke logout() for the c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/guacamole-client/pull/279
---