You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Till Rohrmann (Jira)" <ji...@apache.org> on 2020/05/06 15:21:00 UTC
[jira] [Comment Edited] (FLINK-17527) kubernetes-session.sh uses
log4j-console.properties
[ https://issues.apache.org/jira/browse/FLINK-17527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100381#comment-17100381 ]
Till Rohrmann edited comment on FLINK-17527 at 5/6/20, 3:20 PM:
----------------------------------------------------------------
I am also in favor of unify the logger configuration. When i introduce the {{kubernetes-session.sh}} and using {{log4j-console.properties}}, i have the following thoughts.
* {{log4j-console.properties}} and {{log4j-yarn-session.properties}} are very similar. Both of them output the logs only to console.
* {{log4j-cli.properties}} do not have a corresponding logback configuration file. {{logback.xml}} is used instead.
So maybe we could remove the {{log4j-yarn-session.properties}} and unify the {{log4j-cli.properties}} and {{log4j-console.properties}}. Also the logback configuration files also need to be updated.
was (Author: fly_in_gis):
I am also in favor of unify the logger configuration. When i introduce the {{kubernetes-session.sh}} and using {{log4j-console.properties}}, i have the following thoughts.
* {{log4j-console.properties}} and {{log4j-yarn-session.properties}} are very similar. Both of them output the logs only to console.
* {{log4j-cli.properties}} do not have a corresponding logback configuration file. {{logback.xml}}is used instead.
So maybe we could remove the {{log4j-yarn-session.properties}} and unify the {{log4j-cli.properties}} and {{log4j-console.properties}}. Also the logback configuration files also need to be updated.
> kubernetes-session.sh uses log4j-console.properties
> ---------------------------------------------------
>
> Key: FLINK-17527
> URL: https://issues.apache.org/jira/browse/FLINK-17527
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
> Affects Versions: 1.10.0
> Reporter: Till Rohrmann
> Priority: Major
> Fix For: 1.11.0, 1.10.2
>
>
> It is a bit confusing that {{kubernetes-session.sh}} uses the {{log4j-console.properties}}. At the moment, {{flink}} used {{log4j-cli.properties}}, {{yarn-session.sh}} uses {{log4j-yarn-session.properties}} and {{kubernetes-session.sh}} uses {{log4j-console.properties}}.
> I would suggest to let all scripts use the same logger configuration file (e.g. {{logj4-cli.properties}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)