You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/09/09 01:53:06 UTC
[GitHub] [iceberg] kbendick opened a new pull request #3090: [SPARK] Add in config value needed in tests once SPARK-36128 is suppo…
kbendick opened a new pull request #3090:
URL: https://github.com/apache/iceberg/pull/3090
…rted
The (non-Iceberg) tables generated during testing in `TestAddFiles` procedure are partitioned on date columns that are not casts to strings.
Most metastores will handle this just fine, but Derby and some others will throw an exception. MySQL and Postgres backed metastores will handle this fine and won't need to fall back or generate an exception.
Without setting this, many of the tests in `TestAddFiles` fail with `MetaException(message:Filtering is supported only on partition keys of type string)`
This is related to https://issues.apache.org/jira/browse/SPARK-36128. The consensus in the community was that `false` is the best value for this in production environments as this can in theory have impact on performance, to let users know and adjust their data accordingly.
For tests though, it should probably be set everywhere.
Setting it here now as this is the only place that I've encountered that will need it once https://issues.apache.org/jira/browse/SPARK-36128 is part of a supported version (should be Spark 3.2 which has release candidates though is not GA).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #3090: [SPARK] Add in config value needed in tests once Spark 3.2 is supported
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #3090:
URL: https://github.com/apache/iceberg/pull/3090#issuecomment-915698533
I would set this everywhere, but it gets overridden in subclasses that instantiate their own SparkSession. So I've only set it for the one place I know that will need it.
Possibly we should be instantiating SparkSessions in tests so that they pull down the configuration of their parents? We might see other fringe benefits of instantiating our spark sessions differently, but there could be drawbacks as well (less parallel testing perhaps). Will investigate. But it would be nice if configs were inherited from super classes that instantiate a spark session as almost all cases I've seen just apply the same configs (and maybe a few extra) on the spark session of tests in subclasses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #3090: [SPARK] Add in config value needed in tests once Spark 3.2 is supported
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #3090:
URL: https://github.com/apache/iceberg/pull/3090#issuecomment-915781996
cc @RussellSpitzer since I found this with you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3090: [SPARK] Add in config value needed in tests once Spark 3.2 is supported
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3090:
URL: https://github.com/apache/iceberg/pull/3090#issuecomment-916470561
Thanks for fixing this, @kbendick!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #3090: [SPARK] Add in config value needed in tests once Spark 3.2 is supported
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3090:
URL: https://github.com/apache/iceberg/pull/3090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #3090: [SPARK] Add in config value needed in tests once Spark 3.2 is supported
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #3090:
URL: https://github.com/apache/iceberg/pull/3090#issuecomment-916144845
Looks good to me, I have no problem with merging this now in anticipation. Any folks oppose? @aokolnychyi ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org