You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/09/18 12:54:24 UTC
[GitHub] [kylin] codecov-io edited a comment on issue #760: KYLIN-4097:
Throw exception when too many dict slice evictions in AppendTrieDictionary
codecov-io edited a comment on issue #760: KYLIN-4097: Throw exception when too many dict slice evictions in AppendTrieDictionary
URL: https://github.com/apache/kylin/pull/760#issuecomment-512785042
# [Codecov](https://codecov.io/gh/apache/kylin/pull/760?src=pr&el=h1) Report
> Merging [#760](https://codecov.io/gh/apache/kylin/pull/760?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/199bc17e572652b8a8ec8c4f0c6aab1a2359c1ef?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/kylin/pull/760?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #760 +/- ##
============================================
+ Coverage 25.7% 25.72% +0.01%
- Complexity 6124 6129 +5
============================================
Files 1400 1400
Lines 83729 83746 +17
Branches 11740 11743 +3
============================================
+ Hits 21523 21540 +17
- Misses 60132 60137 +5
+ Partials 2074 2069 -5
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/760?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/760/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.74% <0%> (-0.04%)` | `42 <0> (ø)` | |
| [...va/org/apache/kylin/dict/AppendTrieDictionary.java](https://codecov.io/gh/apache/kylin/pull/760/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L0FwcGVuZFRyaWVEaWN0aW9uYXJ5LmphdmE=) | `67.36% <93.75%> (+9.86%)` | `18 <2> (+5)` | :arrow_up: |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/760/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `51.16% <0%> (-3.49%)` | `8% <0%> (ø)` | |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/760/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
| [...eam/core/storage/columnar/DataSegmentFragment.java](https://codecov.io/gh/apache/kylin/pull/760/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvRGF0YVNlZ21lbnRGcmFnbWVudC5qYXZh) | `57.37% <0%> (-1.64%)` | `17% <0%> (-1%)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/760/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/760/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `78.37% <0%> (+5.4%)` | `7% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/760?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/760?src=pr&el=footer). Last update [199bc17...928e5a7](https://codecov.io/gh/apache/kylin/pull/760?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services