You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by nakomis <gi...@git.apache.org> on 2014/09/16 18:31:34 UTC

[GitHub] incubator-brooklyn pull request: Refactors tests to work around In...

GitHub user nakomis opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/166

    Refactors tests to work around IntelliJ IDEA build issues

    Strictly speaking, this refactoring is unnecessary and undesirable, however it is required in order to work around an IntelliJ IDEA issue that prevents IntelliJ from launching Brooklyn (i.e. by launching `BrooklynJavascriptGuiLauncher`)
    
    With these changes, you can create an IntelliJ Run/Debug configuration that launches `BrooklynJavascriptGuiLauncher`. (In order for the GUI to be available, you need to manually set the working directory of the configuration to e.g. `/Users/martin/Documents/brooklyn/usage/jsgui`)
    
    The issues have been raised with JetBrains here: https://intellij-support.jetbrains.com/requests/38167

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nakomis/incubator-brooklyn fix/intellij-launch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/166.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #166
    
----
commit 3c68339ba914511bfbc128823006dcaabdcd2270
Author: Martin Harris <gi...@nakomis.com>
Date:   2014-09-16T16:27:27Z

    Refactors tests to work around IntelliJ IDEA build issues

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Refactors tests to work around In...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/166


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Refactors tests to work around In...

Posted by andreaturli <gi...@git.apache.org>.

Github user andreaturli commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/166#issuecomment-55860209
  
    lgtm +1
    
    Thanks @nakomis 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Refactors tests to work around In...

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/166#discussion_r17784612
  
    --- Diff: core/src/test/java/brooklyn/entity/hello/LocalEntitiesTest.java ---
    @@ -266,7 +266,7 @@ public void testConfigSetFromAttributeWhenReadyNullTransformations() {
             app.setConfig(HelloEntity.MY_NAME, "Bob");
             
             HelloEntity dad = app.createAndManageChild(EntitySpec.create(HelloEntity.class));
    -        HelloEntity son = entityManager.createEntity(EntitySpec.create(HelloEntity.class)
    +        HelloEntity son = (HelloEntity)entityManager.createEntity(EntitySpec.create(HelloEntity.class)
    --- End diff --
    
    I'd have included a comment to say that cast is there for IntelliJ. Otherwise it risks being removed by someone (or at least distracting them) at some point in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---