[GitHub] [ignite] AMashenkov commented on a change in pull request #9167: IGNITE-13364 Imrove indexes inline defaults

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #9167:
URL: https://github.com/apache/ignite/pull/9167#discussion_r687728412



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/cache/query/index/sorted/IndexKeyDefinition.java
##########
@@ -34,11 +34,20 @@
     /** Order. */
     private final Order order;
 
+    /** Precision for variable length key types. */
+    private final long precision;

Review comment:
       Why we need a 'long' value here?
   It is always cast to 'int', and inline size calculation methods operates with 'int' type.
   
   As I understand max inline size is limited with PageIO.Max_Payload_Size (actually, type of 'short').
   Maybe it make sense to validate if the precision fits this limit or equals to a poison value (Integer.MAX, that means no-limit)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org