You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/11 10:02:58 UTC

[GitHub] [incubator-mxnet] akarbown commented on a change in pull request #20004: Remove USE_MKL_IF_AVAILABLE flag

akarbown commented on a change in pull request #20004:
URL: https://github.com/apache/incubator-mxnet/pull/20004#discussion_r592221577



##########
File path: cmake/ChooseBlas.cmake
##########
@@ -23,14 +23,6 @@ set(INTEL_OPT_ROOT "/opt/intel" CACHE PATH "Folder contains root-installed intel
 
 if(DEFINED USE_BLAS)
   set(BLAS "${USE_BLAS}")
-else()
-  if (USE_MKL_IF_AVAILABLE)
-    # Setting up BLAS_mkl_MKLROOT for non-Ubuntu 20.04 OSes
-    find_path(BLAS_mkl_MKLROOT mkl PATHS $ENV{MKLROOT} ${INTEL_HOME_ROOT} ${INTEL_OPT_ROOT})
-    if(NOT BLAS_mkl_MKLROOT STREQUAL "BLAS_mkl_MKLROOT-NOTFOUND")
-      set(BLAS "MKL")
-    endif()
-  endif()

Review comment:
       If the user doesn't specify any BLAS and USE_MKL_IF_AVAILABLE=ON the 1st priority is MKL, if not available try OpenBLAS and the other that is available. Can you verify that after removing those lines it is still has the same order priority?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org