[jira] [Commented] (PHOENIX-2570) Start transaction manager only when needed and reduce number of threads spawned for tests

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085998#comment-15085998 ] 

James Taylor commented on PHOENIX-2570:
---------------------------------------

Awesome, [~samarthjain]. Thanks so much. Hopefully this will make our Jenkins builds pass consistently. To I make sure I understand, is this a summary of your changes?
- start/stop tx manager per test now instead of per test suite (does that improve performance? Or is it a reliability thing?)
- increase the thread count for index handlers (is that to speed up test execution?)
- set defaults in TEST_PROPERTIES. FWIW, we're pretty good about using TEST_PROPERTIES in most tests, but not all. Will that cause a problem? Would another option be to always set these properties in QueryServicesTestImpl? Individual tests could still override these properties through the override mechanism.

How about setting the default of the forked JVMs to 7 in the pom if you find that's the best?

> Start transaction manager only when needed and reduce number of threads spawned for tests
> -----------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-2570
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2570
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-2570_4.x-HBase-0.98.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)