You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mengxr <gi...@git.apache.org> on 2016/11/01 16:55:51 UTC

[GitHub] spark pull request #15567: [SPARK-14393][SQL] values generated by non-determ...

Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15567#discussion_r85882058
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SparkPartitionID.scala ---
    @@ -17,16 +17,15 @@
     
     package org.apache.spark.sql.catalyst.expressions
     
    -import org.apache.spark.TaskContext
     import org.apache.spark.sql.catalyst.InternalRow
     import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext, ExprCode}
     import org.apache.spark.sql.types.{DataType, IntegerType}
     
     /**
    - * Expression that returns the current partition id of the Spark task.
    + * Expression that returns the current partition id.
      */
     @ExpressionDescription(
    -  usage = "_FUNC_() - Returns the current partition id of the Spark task",
    +  usage = "_FUNC_() - Returns the current partition id",
    --- End diff --
    
    The name is `SparkPartitionID` not `TaskContextPartitionID`. We should follow the same semantic for non-deterministic expressions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org