You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by daan Hoogland <da...@gmail.com> on 2013/07/03 14:20:55 UTC

Review Request 12246: cidr comparator

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12246/
-----------------------------------------------------------

Review request for cloudstack.


Repository: cloudstack-git


Description
-------

fix for a fixme with no comment


Diffs
-----

  server/src/com/cloud/network/security/SecurityGroupManagerImpl.java 1c189c4 
  server/test/com/cloud/network/security/SecurityGroupManagerImplTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12246/diff/


Testing
-------

unit test included


Thanks,

daan Hoogland

Re: Review Request 12246: cidr comparator

Posted by Chip Childers <ch...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12246/#review22714
-----------------------------------------------------------

Ship it!


Applied to master:

commit 141fbc7ef7a89ee1e046366f1e2e6dffbe4e5be7
Author: Daan Hoogland <da...@onecht.net>
Date:   Wed Jul 3 14:03:30 2013 +0200

    cidr compare fixme addressed

Thanks Daan!

- Chip Childers


On July 3, 2013, 12:20 p.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12246/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 12:20 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> fix for a fixme with no comment
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/security/SecurityGroupManagerImpl.java 1c189c4 
>   server/test/com/cloud/network/security/SecurityGroupManagerImplTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12246/diff/
> 
> 
> Testing
> -------
> 
> unit test included
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>