You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/07 10:49:50 UTC
[GitHub] [airflow] BasPH opened a new pull request, #27541: Remove default owner
BasPH opened a new pull request, #27541:
URL: https://github.com/apache/airflow/pull/27541
I suggest removing the default owner config (introduced 7 years ago in https://github.com/apache/airflow/pull/1318), and defaulting `owner` to `None`.
In my experience, the default "airflow" owner never reflects a meaningful entity and thus leads to confusion. Defaulting to None means users have to explicitly set an owner, which aligns better with Python's principle "Explicit is better than implicit".
Currently, you cannot set `owner=None` ([link](https://github.com/apache/airflow/blob/7297892558e94c8cc869b175e904ca96e0752afe/airflow/models/dag.py#L1234)). A workaround is setting an empty string. This PR also fixes the UI to display nothing when the owner is None:
**After**

**Before (with `owner=""`)**

There's likely somebody out there that uses default_owner, so this should be treated as a breaking change.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #27541: Remove default owner
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #27541:
URL: https://github.com/apache/airflow/pull/27541#discussion_r1021006499
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -524,9 +524,6 @@ username =
password =
[operators]
-# The default owner assigned to each new operator, unless
-# provided explicitly or passed via ``default_args``
-default_owner = airflow
Review Comment:
Following the discussion in https://github.com/apache/airflow/pull/27067#discussion_r1020614511 - this seems like a good candidate to remove IF we agree that we can treat "breaking" in a less strict and more "how likely it's going to break other's workflow" way.
Very good example of a case where we could take a risk and classify it as "non-breaking" (even if it is technically a removal).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BasPH commented on a diff in pull request #27541: Remove default owner
Posted by GitBox <gi...@apache.org>.
BasPH commented on code in PR #27541:
URL: https://github.com/apache/airflow/pull/27541#discussion_r1017855186
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -524,9 +524,6 @@ username =
password =
[operators]
-# The default owner assigned to each new operator, unless
-# provided explicitly or passed via ``default_args``
-default_owner = airflow
Review Comment:
I did some research within Astronomer and there's not a single customer setting this option. I figured we might as well remove it for the sake of simplifying Airflow configuration. WDYT?
Either way (remove/change to `None`), this should be treated as a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #27541: Remove default owner
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27541:
URL: https://github.com/apache/airflow/pull/27541#issuecomment-1323376824
Discussion about potential approach we might take for similar cases started in devlist: https://lists.apache.org/thread/1by8ko8jrrp1xwxt5781bwn2tokxjodl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BasPH commented on a diff in pull request #27541: Remove default owner
Posted by GitBox <gi...@apache.org>.
BasPH commented on code in PR #27541:
URL: https://github.com/apache/airflow/pull/27541#discussion_r1015349868
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -524,9 +524,6 @@ username =
password =
[operators]
-# The default owner assigned to each new operator, unless
-# provided explicitly or passed via ``default_args``
-default_owner = airflow
Review Comment:
Yes that's correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BasPH commented on a diff in pull request #27541: Remove default owner
Posted by GitBox <gi...@apache.org>.
BasPH commented on code in PR #27541:
URL: https://github.com/apache/airflow/pull/27541#discussion_r1015349868
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -524,9 +524,6 @@ username =
password =
[operators]
-# The default owner assigned to each new operator, unless
-# provided explicitly or passed via ``default_args``
-default_owner = airflow
Review Comment:
Yes that's correct. Not sure how to best deal with that, should I make a 2nd PR that deprecates the config which can be included with Airflow 2.5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #27541: Remove default owner
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #27541:
URL: https://github.com/apache/airflow/pull/27541#discussion_r1015333944
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -524,9 +524,6 @@ username =
password =
[operators]
-# The default owner assigned to each new operator, unless
-# provided explicitly or passed via ``default_args``
-default_owner = airflow
Review Comment:
What will happen to users who customized their airflow.cfg with
`default_owner = something`
This will no longer work for this... so isn't this a breaking change that we can do only in Airflow 3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #27541: Remove default owner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #27541: Remove default owner
URL: https://github.com/apache/airflow/pull/27541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bolkedebruin commented on pull request #27541: Remove default owner
Posted by GitBox <gi...@apache.org>.
bolkedebruin commented on PR #27541:
URL: https://github.com/apache/airflow/pull/27541#issuecomment-1305431338
+1, don't know the implications, but yes please some code cleanups :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #27541: Remove default owner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #27541:
URL: https://github.com/apache/airflow/pull/27541#issuecomment-1374283993
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on a diff in pull request #27541: Remove default owner
Posted by GitBox <gi...@apache.org>.
o-nikolas commented on code in PR #27541:
URL: https://github.com/apache/airflow/pull/27541#discussion_r1015814625
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -524,9 +524,6 @@ username =
password =
[operators]
-# The default owner assigned to each new operator, unless
-# provided explicitly or passed via ``default_args``
-default_owner = airflow
Review Comment:
Why are we deprecating this at all? I actually like the proposal of not using "airflow" as the default, but I don't see why that means we have to also deprecate the ability for folks to set a default owner at the config level at all? Perhaps they have a default that makes sense for their workflow or organizational structure.
IMHO, this config option should just no longer be a "mandatory" value, but still available to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on a diff in pull request #27541: Remove default owner
Posted by GitBox <gi...@apache.org>.
o-nikolas commented on code in PR #27541:
URL: https://github.com/apache/airflow/pull/27541#discussion_r1023056779
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -524,9 +524,6 @@ username =
password =
[operators]
-# The default owner assigned to each new operator, unless
-# provided explicitly or passed via ``default_args``
-default_owner = airflow
Review Comment:
I agree with Jarek that we could maybe convince ourselves that this is not a hard breaking change, but I actually think this feature is somewhat useful and don't see the motivation for getting rid of it.
We can still keep the ability to set that a globally default user, but just make the config no longer mandatory (since it is currently mandatory). That way you can remove it from the newly published configs, but those users who still have this setting in their configs will not have any regressions and that feature will continue to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BasPH commented on a diff in pull request #27541: Remove default owner
Posted by GitBox <gi...@apache.org>.
BasPH commented on code in PR #27541:
URL: https://github.com/apache/airflow/pull/27541#discussion_r1021443804
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -524,9 +524,6 @@ username =
password =
[operators]
-# The default owner assigned to each new operator, unless
-# provided explicitly or passed via ``default_args``
-default_owner = airflow
Review Comment:
Got a bit lost in that very long message. Are you proposing to discuss the definition of "breaking change"?
In this PR it's clear --> user facing feature, so treat as breaking change, so change in Airflow 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #27541: Remove default owner
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #27541:
URL: https://github.com/apache/airflow/pull/27541#discussion_r1015333944
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -524,9 +524,6 @@ username =
password =
[operators]
-# The default owner assigned to each new operator, unless
-# provided explicitly or passed via ``default_args``
-default_owner = airflow
Review Comment:
What will happens to users who customized their airflow.cfg with
`default_owner = something`
This will no longer work for this... so isn't this a breaking change that we can do only in Airflow 3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org