You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2024/07/11 08:00:14 UTC
Re: [PR] [CELEBORN-1317][FOLLOWUP] Fix media type annotations for form urlencoded APIs [celeborn]
turboFei commented on code in PR #2616:
URL: https://github.com/apache/celeborn/pull/2616#discussion_r1673580367
##########
docs/migration.md:
##########
@@ -40,9 +40,11 @@ license: |
- Since 0.5.0, Celeborn deprecate `celeborn.client.spark.shuffle.forceFallback.enabled`. Please use `celeborn.client.spark.shuffle.fallback.policy` instead.
-- Since 0.5.0, Celeborn master REST API `/exclude` uses POST method and the parameters `add` and `remove` use form parameters instead.
+- Since 0.5.0, Celeborn master REST API `/exclude` uses POST method and the parameters `add` and `remove` use form parameters instead, and use media type `application/x-www-form-urlencoded` instead of `text/plain`.
Review Comment:
updated the pr title and add `annotations` keyword.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org