[GitHub] [airflow] dkim010 commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer

["dkim010 (via GitHub)" <gi...@apache.org>]

dkim010 commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1328604893


##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -403,16 +407,17 @@ def consume_logs(
             """
             last_captured_timestamp = None
             try:
-                logs = self.read_pod_logs(
-                    pod=pod,
-                    container_name=container_name,
-                    timestamps=True,
-                    since_seconds=(
-                        math.ceil((pendulum.now() - since_time).total_seconds()) if since_time else None
-                    ),
-                    follow=follow,
-                    post_termination_timeout=termination_timeout,
-                )
+                if not logs:

Review Comment:
   Okay, I will request again after writing a unit test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org