[GitHub] [arrow] mapleFU commented on a diff in pull request #36290: GH-36284: [Python][Parquet] Support write page index in Python API

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #36290:
URL: https://github.com/apache/arrow/pull/36290#discussion_r1253058005


##########
python/pyarrow/_parquet.pyx:
##########
@@ -493,6 +493,16 @@ cdef class ColumnChunkMetaData(_Weakrefable):
         """Uncompressed size in bytes (int)."""
         return self.metadata.total_uncompressed_size()
 
+    @property
+    def has_offset_index(self):
+        """Has offset index"""

Review Comment:
   To be short, `IndexPage` is not `PageIndex`.
   
   1. https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L536 Currently, index page turns to be something that user defined.
   2. PageIndex is a zonemap for pages
   
   So they are different things



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org