[GitHub] nicolashenry commented on issue #293: GH-292 android: SSL errors handling in Android

[GitBox <gi...@apache.org>]

nicolashenry commented on issue #293: GH-292 android: SSL errors handling in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/293#issuecomment-418641159
 
 
   Before the change, the events came like this : 
   ```js
   {type: "loadstart", url: "https://ourdomain.com/"}
   ```
   ```js
   {type: "loadstop", url: "https://ourdomain.com/"}
   ```
   
   After : 
   ```js
   {type: "loadstart", url: "https://ourdomain.com/"}
   ```
   ```js
   {type: "loaderror", url: "https://ourdomain.com/", code: 0, sslerror: 3, message: "The certificate authority is not trusted"}
   ```
   ```js
   {type: "loadstop", url: "https://ourdomain.com/"}
   ```
   
   The ```handler.cancel();``` is just here to ensure that the connection will not be processed (the default behaviour is to cancel it anyway so the 'super' call is probably already doing it).
   
   I am not sure about what should the ```loaderror``` should have as message, I just copied description from the constants here : https://developer.android.com/reference/android/net/http/SslError 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org