[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #1085: MINIFICPP-1568 Retry PDH processor run to fix test flakiness

[GitBox <gi...@apache.org>]

martinzink commented on pull request #1085:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1085#issuecomment-853051992


   > What is the timing issue? Is it unfeasible to eliminate it instead of a workaround in the test?
   
   The problem is that the processor opens the windows pdh query in the onschedule function, and collects the data in the ontrigger function.
   If there is no usable data in the query then it wont be included in the results.
   From microsofts documentation
   https://docs.microsoft.com/en-us/windows/win32/perfctrs/collecting-performance-data
   Its recommended to wait one second between data collection.
   
   So the onTriggers calls which happen right after the onschedule could lack some fields.
   
   Maybe a cleaner workaround would be if we could schedule the processor separatetly wait a bit than start the triggering, but not sure how big that change would be.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org