You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/30 15:06:52 UTC

[GitHub] [spark] srowen commented on a change in pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table

srowen commented on a change in pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#discussion_r362009641
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/ui/jobs/PoolTable.scala
 ##########
 @@ -34,11 +34,21 @@ private[ui] class PoolTable(pools: Map[Schedulable, PoolData], parent: StagesTab
     <table class="table table-bordered table-striped table-condensed sortable table-fixed">
       <thead>
         <th>Pool Name</th>
-        <th>Minimum Share</th>
-        <th>Pool Weight</th>
+        <th>
+          <span data-toggle="tooltip" data-placement="top" title="Pools can be set a minimum share
+           of CPU cores to allocate">Minimum Share</span>
+        </th>
+        <th>
+          <span title="This controls the pool's share of the cluster relative to other pools"
+           data-toggle="tooltip"  data-placement="top">Pool Weight</span>
+        </th>
         <th>Active Stages</th>
         <th>Running Tasks</th>
-        <th>SchedulingMode</th>
+        <th>
+          <span title="Mode to control whether jobs within the pool queue up behind each other
 
 Review comment:
   Not sure if we can meaningfully elaborate the mode here, maybe leave it.
   Remember that any real docs would exist in the documentation, not here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org