[GitHub] [kafka] KarboniteKream commented on pull request #13679: KAFKA-14291: KRaft controller should return right finalized features in ApiVersionResponse

["KarboniteKream (via GitHub)" <gi...@apache.org>]

KarboniteKream commented on PR #13679:
URL: https://github.com/apache/kafka/pull/13679#issuecomment-1559681643

   This PR seems to have introduced a regression (confirmed using bisect). In a simple setup of two controllers using `config/kraft/controller.properties`, after the leader is shut down and restarted, `UNKNOWN_SERVER_EXCEPTION` will be thrown by `ApiVersionsRequest`.
   
   The other controller sees the following exception:
   ```
   [2023-05-19 15:50:18,834] WARN [QuorumController id=0] getFinalizedFeatures: failed with unknown server exception RuntimeException in 28 us.  The controller is already in standby mode. (org.apache.kafka.controller.QuorumController)
   java.lang.RuntimeException: No in-memory snapshot for epoch 84310. Snapshot epochs are: 61900
       at org.apache.kafka.timeline.SnapshotRegistry.getSnapshot(SnapshotRegistry.java:173)
       at org.apache.kafka.timeline.SnapshotRegistry.iterator(SnapshotRegistry.java:131)
       at org.apache.kafka.timeline.TimelineObject.get(TimelineObject.java:69)
       at org.apache.kafka.controller.FeatureControlManager.finalizedFeatures(FeatureControlManager.java:303)
       at org.apache.kafka.controller.QuorumController.lambda$finalizedFeatures$16(QuorumController.java:2016)
       at org.apache.kafka.controller.QuorumController$ControllerReadEvent.run(QuorumController.java:546)
       at org.apache.kafka.queue.KafkaEventQueue$EventContext.run(KafkaEventQueue.java:127)
       at org.apache.kafka.queue.KafkaEventQueue$EventHandler.handleEvents(KafkaEventQueue.java:210)
       at org.apache.kafka.queue.KafkaEventQueue$EventHandler.run(KafkaEventQueue.java:181)
       at java.base/java.lang.Thread.run(Thread.java:829)
   ```
   
   A similar issue was reported in [KAFKA-14996](https://issues.apache.org/jira/browse/KAFKA-14996). I'll report this in Jira once my account is approved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org