[jira] [Commented] (PROTON-631) Potentiual null pointer exception is JMSType property is present but has a null value.

["Timothy Bish (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062133#comment-14062133 ] 

Timothy Bish commented on PROTON-631:
-------------------------------------

Patch supplied that corrects the check to filter out the JMSType value if a null is set.  It should be fine to no carry forward the value of null as the default behaviour is to return null from the JMSType getter of a javax.jms.Message instance.  

{quote}
>From JMS spec v1.1 section 3.12

"The JMS message interfaces provide write/set methods for setting object
values in a message body and message properties. All of these methods must
be implemented to copy their input objects into the message. The value of an
input object is allowed to be null and will return null when accessed."
{quote}

> Potentiual null pointer exception is JMSType property is present but has a null value.
> --------------------------------------------------------------------------------------
>
>                 Key: PROTON-631
>                 URL: https://issues.apache.org/jira/browse/PROTON-631
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-j
>    Affects Versions: 0.7
>            Reporter: Timothy Bish
>         Attachments: patch.txt
>
>
> If a JMS mapping client sends a message with the "x-opt-jms-type" set but with a value of null the InboundTransformer will throw a NullPointerException since it tries to perform a toString() without first checking for null. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)