You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2020/03/13 12:18:31 UTC
[GitHub] [celix] Oipo opened a new pull request #170: Add new cmake command
for explicitly installing docker containers
Oipo opened a new pull request #170: Add new cmake command for explicitly installing docker containers
URL: https://github.com/apache/celix/pull/170
Add new cmake command for explicitly installing docker containers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] pnoltes merged pull request #170: Add new cmake command for
explicitly installing docker containers
Posted by GitBox <gi...@apache.org>.
pnoltes merged pull request #170: Add new cmake command for explicitly installing docker containers
URL: https://github.com/apache/celix/pull/170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] Oipo commented on issue #170: Add new cmake command for
explicitly installing docker containers
Posted by GitBox <gi...@apache.org>.
Oipo commented on issue #170: Add new cmake command for explicitly installing docker containers
URL: https://github.com/apache/celix/pull/170#issuecomment-598693913
@abroekhuis Please also take a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] abroekhuis commented on a change in pull request #170: Add
new cmake command for explicitly installing docker containers
Posted by GitBox <gi...@apache.org>.
abroekhuis commented on a change in pull request #170: Add new cmake command for explicitly installing docker containers
URL: https://github.com/apache/celix/pull/170#discussion_r392240394
##########
File path: cmake/cmake_celix/DockerPackaging.cmake
##########
@@ -543,4 +525,57 @@ function(cmake_docker_add_files)
COMMENT "Copying file '${DOCKER_FILE}' to '${DOCKER_DIR_LOCATION}/${DOCKER_DESTINATION}'"
)
endforeach()
+endfunction()
+
+
+#[[
+Install docker container when 'make install' is executed and CELIX_BUILD_DOCKER_USE_DOCKER_DIR_TAR is defined.
+Docker containers are installed at `<install-prefix>/shared/<project_name>/containers`.
+
+CELIX_BUILD_DOCKER_TAR_LOCATION can be defined to override the default install-prefix.
+
+Optional arguments:
+- PROJECT_NAME: The project name for installing. Default is the cmake project name.
+- IMAGE_NAME: Configure the image name. Default is NAME.
+
+install_celix_docker_targz(<docker_target_name>
Review comment:
Is there also an alternative to targz? If not, why the suffix targz?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services