You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2025/10/09 10:09:08 UTC
[PR] chore: Exclude hudi-trino-plugin from RAT checks [hudi]
voonhous opened a new pull request, #14067:
URL: https://github.com/apache/hudi/pull/14067
### Describe the issue this Pull Request addresses
This PR addresses issue https://github.com/apache/hudi/issues/14066 by excluding `hudi-trino-plugin` from RAT checks.
### Summary and Changelog
1. Exclude `hudi-trino-plugin` from RAT checks.
### Impact
None
### Risk Level
None
### Documentation Update
None
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Exclude hudi-trino-plugin from RAT checks [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14067:
URL: https://github.com/apache/hudi/pull/14067#issuecomment-3385520140
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44e3b4b1130e31b5a2736db6a4f1be823fad7970",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9115",
"triggerID" : "44e3b4b1130e31b5a2736db6a4f1be823fad7970",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44e3b4b1130e31b5a2736db6a4f1be823fad7970 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9115)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Exclude hudi-trino-plugin from RAT checks [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14067:
URL: https://github.com/apache/hudi/pull/14067#issuecomment-3385142220
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44e3b4b1130e31b5a2736db6a4f1be823fad7970",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "44e3b4b1130e31b5a2736db6a4f1be823fad7970",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44e3b4b1130e31b5a2736db6a4f1be823fad7970 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Exclude hudi-trino-plugin from RAT checks [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14067:
URL: https://github.com/apache/hudi/pull/14067#issuecomment-3385146504
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44e3b4b1130e31b5a2736db6a4f1be823fad7970",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9115",
"triggerID" : "44e3b4b1130e31b5a2736db6a4f1be823fad7970",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44e3b4b1130e31b5a2736db6a4f1be823fad7970 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9115)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Exclude hudi-trino-plugin from RAT checks [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #14067:
URL: https://github.com/apache/hudi/pull/14067#discussion_r2416831738
##########
pom.xml:
##########
@@ -614,6 +614,7 @@
<!-- local files not in version control -->
<exclude>**/*.iml</exclude>
<exclude>.mvn/**</exclude>
+ <exclude>hudi-trino-plugin/**</exclude>
Review Comment:
Possible, but any concerns regarding excluding the whole module since the module has it's own license checks that are already handled by airbase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Exclude hudi-trino-plugin from RAT checks [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #14067:
URL: https://github.com/apache/hudi/pull/14067#discussion_r2418383800
##########
pom.xml:
##########
@@ -614,6 +614,7 @@
<!-- local files not in version control -->
<exclude>**/*.iml</exclude>
<exclude>.mvn/**</exclude>
+ <exclude>hudi-trino-plugin/**</exclude>
Review Comment:
Got it. Then let's keep it as is. It would be better to align the license check to avoid the discrepancy between `hudi-trino-plugin` and other modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Exclude hudi-trino-plugin from RAT checks [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #14067:
URL: https://github.com/apache/hudi/pull/14067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Exclude hudi-trino-plugin from RAT checks [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #14067:
URL: https://github.com/apache/hudi/pull/14067#discussion_r2416378997
##########
pom.xml:
##########
@@ -614,6 +614,7 @@
<!-- local files not in version control -->
<exclude>**/*.iml</exclude>
<exclude>.mvn/**</exclude>
+ <exclude>hudi-trino-plugin/**</exclude>
Review Comment:
Could certain files be excluded instead of the whole module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org