[GitHub] ctubbsii commented on a change in pull request #792: Updates to client builder API

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #792: Updates to client builder API
URL: https://github.com/apache/accumulo/pull/792#discussion_r238029597
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/clientImpl/AccumuloClientImpl.java
 ##########
 @@ -283,12 +287,21 @@ public void close() {
     }
   }
 
-  public static class AccumuloClientBuilderImpl
-      implements InstanceArgs, PropertyOptions, ClientInfoOptions, AuthenticationArgs,
-      ConnectionOptions, SslOptions, SaslOptions, AccumuloClientFactory, FromOptions {
+  public static class ClientBuilderImpl<T>
+      implements InstanceArgs<T>, PropertyOptions<T>, AuthenticationArgs<T>, ConnectionOptions<T>,
+      SslOptions<T>, SaslOptions<T>, ClientFactory<T>, FromOptions<T> {
 
     private Properties properties = new Properties();
     private AuthenticationToken token = null;
+    private BuildFunction<T> builderFunction;
 
 Review comment:
   The `BuildFunction` interface isn't needed. Can just use `Function<ClientBuilderImpl, T>` here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services